fix!: Migrate file destination to SDK v2 #9855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
reviewed
Apr 17, 2023
disq
reviewed
Apr 17, 2023
disq
reviewed
Apr 17, 2023
disq
reviewed
Apr 17, 2023
Member
Author
|
This PR is now almost ready - it works in local testing, but the tests warn us about some memory leaks that I need to track down next. |
hermanschaaf
changed the title
hermanschaaf
requested review from
a team and
amanenk
and removed request for
a team
disq
reviewed
Apr 20, 2023
disq
reviewed
Apr 20, 2023
disq
reviewed
Apr 20, 2023
disq
reviewed
Apr 20, 2023
disq
reviewed
Apr 20, 2023
disq
reviewed
Apr 20, 2023
disq
reviewed
Apr 20, 2023
disq
approved these changes
Apr 20, 2023
hermanschaaf
changed the title
erezrokah
approved these changes
Apr 20, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the following:
pathparameter to allow for more flexible naming of the output files. The olddirectoryparameter is still supported, but will be removed in a future version and for now a warning is logged when it is used. When upgrading to v2.0.0, please consider changing fromdirectorytopathas well.BEGIN_COMMIT_OVERRIDE
feat: Update to use Apache Arrow type system
feat: Introduce
pathparameter with placeholder variables to replacedirectory. Please consider updating your config to usepathinstead ofdirectory.BREAKING-CHANGE: This release introduces an internal change to our type system to use Apache Arrow. This should not have any visible breaking changes for CSV or JSON output formats, however the Parquet output changes for UUID columns, which now have dashes, and timestamps, which now uses the default Arrow time format (e.g.
2023-01-02 12:23:45). If you encounter an issue during the upgrade, please submit a bug report.END_COMMIT_OVERRIDE
Closes #10114