feat(meilisearch)!: Upgrade to github.com/cloudquery/plugin-sdk/v2
#9852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
requested review from
a team and
amanenk
and removed request for
a team
candiduslynx
requested review from
a team and
yevgenypats
and removed request for
amanenk
candiduslynx
force-pushed
the
feat/plugin-sdk-upgrade/meilisearch
branch
2 times, most recently
from
e54d118 to
2d7a003
Compare
candiduslynx
changed the title
github.com/cloudquery/plugin-sdk/v2github.com/cloudquery/plugin-sdk/v2
yevgenypats
suggested changes
Apr 18, 2023
disq
reviewed
Apr 18, 2023
disq
reviewed
Apr 18, 2023
candiduslynx
force-pushed
the
feat/plugin-sdk-upgrade/meilisearch
branch
from
e5b39cd to
43823fa
Compare
candiduslynx
force-pushed
the
feat/plugin-sdk-upgrade/meilisearch
branch
from
43823fa to
fdee317
Compare
yevgenypats
suggested changes
Apr 19, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good. First round of review. found a few low hanging fruits.
yevgenypats
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9849
BEGIN_COMMIT_OVERRIDE
feat: Update to use Apache Arrow type system
BREAKING-CHANGE: This release introduces an internal change to our type system to use Apache Arrow. This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a bug report.
END_COMMIT_OVERRIDE