feat(mongodb): Create unique indexes for PKs #9851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
requested review from
a team and
yevgenypats
and removed request for
a team
disq
commented
Apr 12, 2023
| if c.spec.WriteMode == specs.WriteModeOverwriteDeleteStale { | ||
| delIndexName := "cq_del" | ||
| indexes = append(indexes, mongo.IndexModel{ | ||
| Keys: bson.D{{Key: schema.CqSourceNameColumn.Name, Value: 1}, {Key: schema.CqSyncTimeColumn.Name, Value: 1}}, |
Member
Author
There was a problem hiding this comment.
Not sure about the values here.
disq
commented
Apr 12, 2023
| func (c *Client) migrateTable(ctx context.Context, table *schema.Table) error { | ||
| indexModels := c.getIndexTemplates(table) | ||
| for _, mdl := range indexModels { | ||
| res, err := c.client.Database(c.pluginSpec.Database).Collection(table.Name).Indexes().CreateOne(ctx, mdl) |
Member
Author
There was a problem hiding this comment.
There's CreateMany as well but it would get complicated to do the error handling afterwards. It fails on the first error and you'd have to do re-runs to check/handle all.
disq
commented
Apr 12, 2023
| return false | ||
| } | ||
|
|
||
| // This is either "Index already exists with a different name: %s" error or due to uniqueness change |
Member
Author
There was a problem hiding this comment.
If they want non-unique indexes in cq_pk, they can have it?
candiduslynx
approved these changes
Apr 12, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.0](plugins-destination-mongodb-v1.1.5...plugins-destination-mongodb-v2.0.0) (2023-04-25) ### ⚠ BREAKING CHANGES * This release introduces an internal change to our type system to use [Apache Arrow](https://arrow.apache.org/). This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a [bug report](https://github.com/cloudquery/cloudquery/issues/new/choose). ### Features * **mongodb:** Create unique indexes for PKs ([#9851](#9851)) ([9e20642](9e20642)) * Update to use [Apache Arrow](https://arrow.apache.org/) type system ([9e74b76](9e74b76)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.45.0 ([#9863](#9863)) ([2799d62](2799d62)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.4.0 ([#10278](#10278)) ([a0a713e](a0a713e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9614
Checking with
db.system.profile.find().limit(5).pretty()afterdb.setProfilingLevel(2)I don't see anyCOLLSCANs.We're not adding indexes for_cq_source_name,_cq_sync_timesoDeleteStaleis probably still slow.Verified with
db.system.profile.find({ "planSummary": "COLLSCAN", "ns": { "$ne": "mdb.system.profile" } })as well.