fix(aws): Replace Manually paginated calls with paginator where available #9765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
changed the title
candiduslynx
approved these changes
Apr 8, 2023
Contributor
There was a problem hiding this comment.
Only a couple notes on places where using maps.Copy would make sense.
Can be left out for a follow-up PR.
| } | ||
|
|
||
| for k, v := range result.Tags { | ||
| for k, v := range page.Tags { |
Contributor
| return err | ||
| } | ||
| for k, v := range result.Tags { | ||
| for k, v := range page.Tags { |
Contributor
erezrokah
approved these changes
Apr 9, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [16.1.0](plugins-source-aws-v16.0.1...plugins-source-aws-v16.1.0) (2023-04-11) ### Features * **aws-services:** Support newly added regions ([#9821](#9821)) ([4d7f388](4d7f388)) * **aws:** Parallelize resolution of `aws_iot_billing_groups` ([#9809](#9809)) ([e759661](e759661)) * **aws:** Parallelize resolution of `aws_iot_ca_certificates` ([#9808](#9808)) ([d491460](d491460)) * **aws:** Parallelize resolution of `aws_iot_jobs` ([#9810](#9810)) ([9b85678](9b85678)) * **aws:** Parallelize resolution of `aws_iot_policies` ([#9806](#9806)) ([b9a9d06](b9a9d06)) * **aws:** Parallelize resolution of `aws_iot_security_profiles` ([#9807](#9807)) ([45705f1](45705f1)) * **aws:** Parallelize resolution of `aws_iot_streams` ([#9804](#9804)) ([9b622e0](9b622e0)) * **aws:** Parallelize resolution of `aws_iot_thing_groups` ([#9805](#9805)) ([f5047b9](f5047b9)) * **aws:** Parallelize resolution of `aws_iot_topic_rules` ([#9803](#9803)) ([d344815](d344815)) ### Bug Fixes * **aws-policies:** Update Query to properly handle a string and array ([#9815](#9815)) ([012347f](012347f)), closes [#9763](#9763) * **aws:** Inspector Classic fetch details use proper limits ([#9816](#9816)) ([225a796](225a796)) * **aws:** Replace Manually paginated calls with paginator where available ([#9765](#9765)) ([b64d152](b64d152)) * **aws:** Replace more manual pagination with Paginator objects ([#9754](#9754)) ([1d27dca](1d27dca)) * **deps:** Update module github.com/aws/aws-sdk-go-v2 to v1.17.8 ([#9781](#9781)) ([69bb790](69bb790)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.20 ([#9782](#9782)) ([1febd5b](1febd5b)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.61 ([#9791](#9791)) ([f9dcef8](f9dcef8)) * Fix case on arn attribute ([#9757](#9757)) ([0719095](0719095)) * Use aws.ToString(output.NextToken) when checking tokens ([#9750](#9750)) ([7670494](7670494)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the follow regex to find all paginated AWS calls:
aws.ToString\([A-Z a-z]*\.[A-Z a-z]*\) == ""Manually paginated calls were replaced with paginators. If a call doesn't support a paginator a comment was added