feat(sqlite): Migrate to apache arrow type system #9751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
reviewed
Apr 10, 2023
Member
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
Did a quick review of the code to make sure I get a general idea.
If you can update the go.mod to update to commit I can also test (or tell me which versions of SDK/Arrow to use).
yevgenypats
requested review from
a team and
disq
and removed request for
a team
yevgenypats
changed the title
yevgenypats
force-pushed
the
feat/sqlite_arrow
branch
from
71eed8d to
695d677
Compare
1 task
yevgenypats
force-pushed
the
feat/sqlite_arrow
branch
from
c71116f to
1717ff0
Compare
Contributor
Author
Thanks @erezrokah go.mod should be up to date now. |
erezrokah
approved these changes
Apr 17, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.0](plugins-destination-sqlite-v1.3.6...plugins-destination-sqlite-v2.0.0) (2023-04-17) ### ⚠ BREAKING CHANGES * This release introduces an internal change to our type system to use [Apache Arrow](https://arrow.apache.org/). This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a [bug report](https://github.com/cloudquery/cloudquery/issues/new/choose). ### Features * **sqlite:** Migrate to apache arrow type system ([#9751](#9751)) ([549a38e](549a38e)) * Update to use arrow type system ([a55e0fb](a55e0fb)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.45.0 ([#9863](#9863)) ([2799d62](2799d62)) * **sqlite:** Make arrow work with older sources ([#10141](#10141)) ([eef77bb](eef77bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still wait for another sdkv2 release for tests to pass but should be ready for initial review.