feat(azure-resources): Add Consumption Resources #9117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
erezrokah
force-pushed
the
feat/azure_consumption_data
branch
from
80d63fb to
a1121a5
Compare
erezrokah
force-pushed
the
feat/azure_consumption_data
branch
from
a1121a5 to
c2664ed
Compare
Member
Author
|
Moved back to draft, see #8929 (comment) |
erezrokah
force-pushed
the
feat/azure_consumption_data
branch
2 times, most recently
from
36286c9 to
d3da081
Compare
erezrokah
force-pushed
the
feat/azure_consumption_data
branch
from
d3da081 to
c267d0f
Compare
Member
Author
|
I'll do a bit more testing, but this is mostly ready. It's a bit hard to test as I don't have access to old account types (I did get some tables to work on my personal account). It's mostly based on the Azure REST API docs and ensures we send the same requests |
erezrokah
force-pushed
the
feat/azure_consumption_data
branch
from
c267d0f to
559f767
Compare
erezrokah
force-pushed
the
feat/azure_consumption_data
branch
from
e5f9888 to
2cecb09
Compare
erezrokah
force-pushed
the
feat/azure_consumption_data
branch
from
dbf4a17 to
df49e5d
Compare
yevgenypats
approved these changes
Apr 20, 2023
erezrokah
force-pushed
the
feat/azure_consumption_data
branch
from
df49e5d to
3424606
Compare
Member
Author
|
Hi @yevgenypats and thanks for the review. I updated this PR with 3 additional commits:
I'll update the issue to get more feedback so I suggest we wait on reviewing the new changes until we receive it. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 23, 2023
🤖 I have created a release *beep* *boop* --- ## [7.2.0](plugins-source-azure-v7.1.1...plugins-source-azure-v7.2.0) (2023-04-23) ### This Release has the Following Changes to Tables - Table `azure_consumption_billing_account_balances` was added - Table `azure_consumption_billing_account_budgets` was added - Table `azure_consumption_billing_account_charges` was added - Table `azure_consumption_billing_account_events` was added - Table `azure_consumption_billing_account_legacy_usage_details` was added - Table `azure_consumption_billing_account_lots` was added - Table `azure_consumption_billing_account_marketplaces` was added - Table `azure_consumption_billing_account_modern_usage_details` was added - Table `azure_consumption_billing_account_reservation_recommendations` was added - Table `azure_consumption_billing_account_tags` was added - Table `azure_consumption_billing_profile_reservation_details` was added - Table `azure_consumption_billing_profile_reservation_recommendations` was added - Table `azure_consumption_billing_profile_reservation_summaries` was added - Table `azure_consumption_billing_profile_reservation_transactions` was added - Table `azure_consumption_subscription_budgets` was added - Table `azure_consumption_subscription_legacy_usage_details` was added - Table `azure_consumption_subscription_marketplaces` was added - Table `azure_consumption_subscription_price_sheets` was added - Table `azure_consumption_subscription_reservation_recommendations` was added - Table `azure_consumption_subscription_tags` was added ### Features * **azure-resources:** Add Consumption Resources ([#9117](#9117)) ([007421a](007421a)) * **azure:** Add policy docs ([#10253](#10253)) ([e5b9ec7](e5b9ec7)) * **azure:** Upgrade to `github.com/cloudquery/plugin-sdk/v2` ([#9943](#9943)) ([11d98b3](11d98b3)), closes [#9942](#9942) ### Bug Fixes * **azure:** Added missing character ([#10183](#10183)) ([cbd948d](cbd948d)) * **azure:** Fix detecting conditions in CIS Section 8 ([#9923](#9923)) ([612da16](612da16)) * **Azure:** Reduce duplicate results of Azure CIS v1.3.0 Section 9.1 ([#10013](#10013)) ([6539ee3](6539ee3)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.2.0 ([#10135](#10135)) ([cf33b89](cf33b89)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.2.2 ([#10143](#10143)) ([8f887e0](8f887e0)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.0 ([#10163](#10163)) ([9a7f214](9a7f214)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.1 ([#10175](#10175)) ([5b53423](5b53423)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.3 ([#10187](#10187)) ([b185248](b185248)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.4 ([#10196](#10196)) ([c6d2f59](c6d2f59)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.5 ([#10200](#10200)) ([5a33693](5a33693)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.6 ([#10208](#10208)) ([91c80a7](91c80a7)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.8 ([#10213](#10213)) ([f358666](f358666)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8929.
Notes
scopeargument that can be a subscription, billing account, billing account, enrollment account, and more. See example in https://learn.microsoft.com/en-us/rest/api/consumption/usage-details/list?tabs=HTTP#uri-parameters. We could support all scopes, but I'm starting with only billing account, profiles and subscriptions, based on the API so the result will have the "Modern" or "Legacy" struct returned (where applicable).