fix(postgres): Better error message on unknown types, add missing float types #8475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Feb 27, 2023
| return schema.TypeBool | ||
| case "bigint", "integer": | ||
| return schema.TypeInt | ||
| case "double precision": |
Member
Author
There was a problem hiding this comment.
Our query that reads the current schema returns TypeFloat as PostgreSQL real, so this code always failed on a table that has floats columns. I added both float and real to the supported types
yevgenypats
approved these changes
Feb 27, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
🤖 I have created a release *beep* *boop* --- ## [2.1.4](plugins-destination-postgresql-v2.1.3...plugins-destination-postgresql-v2.1.4) (2023-02-27) ### Bug Fixes * **postgres:** Better error message on unknown types, add missing float types ([#8475](#8475)) ([7bada3b](7bada3b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8436.
It also adds missing types for
double precision. The query we use returns it asrealso the code failed when trying to read a table that has floats