feat(deps)!: Update MSSQL plugin-sdk to v1.39.1 #8318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
erezrokah
commented
Feb 21, 2023
| [_cq_parent_id] uniqueidentifier, | ||
| [_cq_source_name] nvarchar(4000), | ||
| [_cq_sync_time] datetimeoffset, | ||
| [_cq_sync_time] datetime2, |
Member
Author
There was a problem hiding this comment.
datetimeoffset saves the time zone information so if we write a time.Time and then read it the time zone information gets added and we get a different value than the original (see comment in PR description and
erezrokah
requested review from
a team,
candiduslynx and
yevgenypats
and removed request for
a team
erezrokah
force-pushed
the
feat/update_mssql_sdk
branch
from
de4c7d3 to
f7f5cc8
Compare
candiduslynx
suggested changes
Feb 21, 2023
| [_cq_parent_id] uniqueidentifier, | ||
| [_cq_source_name] nvarchar(4000), | ||
| [_cq_sync_time] datetimeoffset, | ||
| [_cq_sync_time] datetime2, |
| [_cq_parent_id] uniqueidentifier, | ||
| [_cq_source_name] nvarchar(4000), | ||
| [_cq_sync_time] datetimeoffset, | ||
| [_cq_sync_time] datetime2, |
Contributor
candiduslynx
left a comment
candiduslynx
left a comment
There was a problem hiding this comment.
I'm OK with the changes, however, I think we need to address cloudquery/plugin-sdk#700 prior to merging this
erezrokah
changed the title
erezrokah
force-pushed
the
feat/update_mssql_sdk
branch
from
2cc6640 to
b442896
Compare
Member
Author
|
@candiduslynx small follow up in b442896 (still needs the UTC fix though) |
erezrokah
changed the title
16 tasks
Co-authored-by: candiduslynx <[email protected]>
erezrokah
force-pushed
the
feat/update_mssql_sdk
branch
from
c610cf2 to
99235be
Compare
Member
Author
|
@candiduslynx 99235be is related to #8436 |
Member
Author
|
@candiduslynx see cloudquery/plugin-sdk#716. I think the impact of cloudquery/plugin-sdk#700 is not that big |
candiduslynx
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Same as #7819 for MSSQL.
This is a breaking change due to the type change from
datetimeoffsettodatetime2as we don't want to save time zone offset, seecloudquery/plugins/destination/postgresql/client/types.go
Line 74 in ee4b2c0
I suggest following the code in an IDE as it's hard to understand the changes from the diff.
BEGIN_COMMIT_OVERRIDE
feat(deps): Update MSSQL plugin-sdk to v1.38.2
BREAKING-CHANGE: Update MSSQL plugin-sdk to v1.38.2. You'll need to drop the database and start fresh due to a change in the schema for all timestamp columns from
datetimeoffsettodatetime2.END_COMMIT_OVERRIDE