feat(deps): Update File plugin-sdk to v1.38.2 #8262
Conversation
erezrokah
requested review from
a team and
hermanschaaf
and removed request for
a team
| ) | ||
|
|
||
| var migrateStrategy = destination.MigrateStrategy{ | ||
| AddColumn: specs.MigrateModeForced, |
There was a problem hiding this comment.
Add is forced mostly because of CSV as we also need to update the headers and enter empty values if we want to do this right (which we probably don't want to do now)
| SkipOverwrite: true, | ||
| SkipDeleteStale: true, | ||
| SkipSecondAppend: true, | ||
| SkipMigrateAppend: true, |
There was a problem hiding this comment.
Parquet format doesn't support any changes or appends once the file footer is written.
There was a problem hiding this comment.
OK so the tests API is a bit confusing but this will be skipped actually since the migrate strategy is forced:
https://github.com/cloudquery/plugin-sdk/blob/fac9ed3681d4f10800274a6bd35d2fa9cdcc732d/plugins/destination/plugin_testing_migrate.go#L91
Once we add support for forced mode (which will probably just delete the existing file), we'll need to remove SkipMigrateAppendForce and then it will verify the forced append work 🙃
There was a problem hiding this comment.
See also https://github.com/cloudquery/plugin-sdk/blob/fac9ed3681d4f10800274a6bd35d2fa9cdcc732d/plugins/destination/plugin_testing.go#L158 vs https://github.com/cloudquery/plugin-sdk/blob/fac9ed3681d4f10800274a6bd35d2fa9cdcc732d/plugins/destination/plugin_testing.go#L169
| SkipMigrateAppend: true, | ||
| SkipMigrateOverwrite: true, | ||
| SkipMigrateOverwriteForce: true, | ||
| SkipMigrateAppendForce: true, |
There was a problem hiding this comment.
We can remove SkipMigrateOverwriteForce and SkipMigrateAppendForce once we add support for forced mode, but out of scope for this PR
🤖 I have created a release *beep* *boop* --- ## [1.2.0](plugins-destination-file-v1.1.1...plugins-destination-file-v1.2.0) (2023-02-21) ### Features * **deps:** Update File plugin-sdk to v1.38.2 ([#8262](#8262)) ([97c7b01](97c7b01)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/filetypes to v1.4.2 ([#8218](#8218)) ([9e656c2](9e656c2)) * **deps:** Update module golang.org/x/net to v0.7.0 [SECURITY] ([#8176](#8176)) ([fc4cef8](fc4cef8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
3 participants
Summary
Extracted from #8156.
For file destination we can only do force for every change (we might be able to do add and remove column safely for JSON as it's simply adding/removing a new field to the JSON object which should be fine. Out of scope for this PR).