feat(deps): Update Elasticsearch plugin-sdk to v1.38.2 #8259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
requested review from
a team,
hermanschaaf and
shimonp21
and removed request for
a team and
shimonp21
erezrokah
force-pushed
the
feat/update_elasticsearch_sdk
branch
from
d058e8e to
c9b5dd0
Compare
erezrokah
commented
Feb 20, 2023
candiduslynx
suggested changes
Feb 20, 2023
Co-authored-by: candiduslynx <[email protected]>
candiduslynx
approved these changes
Feb 21, 2023
Contributor
candiduslynx
left a comment
candiduslynx
left a comment
There was a problem hiding this comment.
I'm approving but removing automerge bc the original author (@hermanschaaf) should take a look, too.
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-destination-elasticsearch-v1.0.6...plugins-destination-elasticsearch-v1.1.0) (2023-02-21) ### Features * **deps:** Update Elasticsearch plugin-sdk to v1.38.2 ([#8259](#8259)) ([0e852ed](0e852ed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
#### Summary Updates MongoDB to the new SDK with the following issues discovered in the tests: - In overwrite mode, for a table with no PKs we used an empty filter always overwriting. The fix is similar to #8259 to use all columns as the filter - When reading timestamp the Go lib uses local timezone. We want to read it as UTC (assuming it's written as UTC). <!--
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #8156 as it requires an additional fix.
If the table doesn't have any PKs and in overwrite mode(s) we can only write a single resource per table as the doc ID will always be the same.
This PR changes it so if there are no PKs, we use all columns for the doc ID.