Skip to content

chore(file): Enable JSON:SkipMigrateAppend in testing #8256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 3 commits into from
Feb 20, 2023
Merged

chore(file): Enable JSON:SkipMigrateAppend in testing #8256

kodiakhq merged 3 commits into from
Feb 20, 2023

Conversation

@disq
Copy link
Member

@disq disq commented Feb 20, 2023 •
edited
Loading

filetypes update (PR) fails otherwise.

@disq disq requested review from a team, erezrokah and yevgenypats and removed request for a team February 20, 2023 10:31
@cq-bot cq-bot added the file label Feb 20, 2023
erezrokah
erezrokah approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to unblock the PR, but let's update the title to reflect it does dep updates as the testing change is not relevant to users.

I think the "proper" fix should be to set a migrate strategy for the append tests, but I'll do that separately

@disq disq changed the title fix(file): Enable JSON:SkipMigrateAppend in testing chore(file): Enable JSON:SkipMigrateAppend in testing Feb 20, 2023
@disq
Copy link
Member Author

disq commented Feb 20, 2023

@erezrokah Renamed as chore. This only applies to the file plugin that's why it's chore(file) and not fix(deps).

@erezrokah
Copy link
Member

erezrokah commented Feb 20, 2023

@erezrokah Renamed as chore. This only applies to the file plugin that's why it's chore(file) and not fix(deps).

It updates dependencies which is a user facing change so it should be at least fix. For example this update includes cloudquery/filetypes#71

@disq
Copy link
Member Author

disq commented Feb 20, 2023

Ah sorry it wasn't meant to update dependencies. Fixing

@disq
Copy link
Member Author

disq commented Feb 20, 2023

@erezrokah not updating dependencies any more, that will be done by the linked PR.

@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Feb 20, 2023
@kodiakhq kodiakhq bot merged commit 4ccaa3d into cloudquery:main Feb 20, 2023
@disq disq deleted the fix/file-json-append branch February 20, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@erezrokah erezrokah erezrokah approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

+1 more reviewer

@candiduslynx candiduslynx candiduslynx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@disq @erezrokah @hermanschaaf @candiduslynx @cq-bot