Skip to content

feat(azure): Add network: interface_ip_configurations and virtual_network_subnets #8126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 3 commits into from
Feb 15, 2023
Merged

feat(azure): Add network: interface_ip_configurations and virtual_network_subnets #8126

kodiakhq merged 3 commits into from
Feb 15, 2023

Conversation

@disq
Copy link
Member

@disq disq commented Feb 15, 2023

Implements #7929

@github-actions
Copy link

github-actions bot commented Feb 15, 2023

This PR has the following changes to source plugin(s) tables:

  • Table azure_network_interface_ip_configurations was added
  • Table azure_network_virtual_network_subnets was added

@disq disq linked an issue Feb 15, 2023 that may be closed by this pull request
Azure Network Resources #7929
Closed
erezrokah
erezrokah reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@erezrokah erezrokah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @disq, but I think we don't add a reference to the parent unless required for PK purposes, isn't ID enough for that?

@disq
Copy link
Member Author

disq commented Feb 15, 2023

Looks great @disq, but I think we don't add a reference to the parent unless required for PK purposes, isn't ID enough for that?

Yes ID includes the PK but wouldn't it be hard to match with parent as one would have to parse the ID and remove the last two parts (/databases/<name>) to get to the parent?

@erezrokah
Copy link
Member

erezrokah commented Feb 15, 2023 •
edited
Loading

Yes ID includes the PK but wouldn't it be hard to match with parent as one would have to parse the ID and remove the last two parts (/databases/<name>) to get to the parent?

I agree. My comment is intedened to keep the plugin consistent. If we add a parent ref we should do it for all relational tables and decide on a naming convention so maybe out of scope for this PR. cc @yevgenypats

@disq disq added the automerge Automatically merge once required checks pass label Feb 15, 2023
@kodiakhq kodiakhq bot merged commit df5e48b into cloudquery:main Feb 15, 2023
@disq disq deleted the feat/azure_network_resources branch February 15, 2023 13:10
@cq-bot cq-bot mentioned this pull request Feb 15, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Feb 21, 2023
@cq-bot
chore(main): Release plugins-source-azure v4.2.0 (#8123)
c228a39 
🤖 I have created a release *beep* *boop*
---


## [4.2.0](plugins-source-azure-v4.1.1...plugins-source-azure-v4.2.0) (2023-02-21)


### Features

* **azure:** Add network ExpressRoute circuit authorizations and peerings ([#8128](#8128)) ([2d4cba5](2d4cba5)), closes [#7927](#7927)
* **azure:** Add network: interface_ip_configurations and virtual_network_subnets ([#8126](#8126)) ([df5e48b](df5e48b)), closes [#7929](#7929)
* **azure:** Add postgresql databases resource ([#8125](#8125)) ([91cab61](91cab61)), closes [#7928](#7928)


### Bug Fixes

* **azure:** Ensure spec subscriptions are unique ([#8099](#8099)) ([20dc235](20dc235))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.38.2 ([#8156](#8156)) ([ac2d2d7](ac2d2d7))
* **deps:** Update module golang.org/x/net to v0.7.0 [SECURITY] ([#8176](#8176)) ([fc4cef8](fc4cef8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erezrokah erezrokah erezrokah approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Azure Network Resources

3 participants

@disq @erezrokah @cq-bot