fix(azure): Ensure spec subscriptions are unique #8099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil, fmt.Errorf("failed to unmarshal gcp spec: %w", err) | ||
| } | ||
|
|
||
| uniqueSubscriptions := funk.Uniq(spec.Subscriptions).([]string) |
Contributor
There was a problem hiding this comment.
I'd rather use slices.Compact along with slices.Sort
Suggested change
| uniqueSubscriptions := funk.Uniq(spec.Subscriptions).([]string) | |
| uniqueSubscriptions := slices.Compact(slices.Sort(spec.Subscriptions)) |
Contributor
There was a problem hiding this comment.
(because it's a part of Go tooling & they're bringing this package to main stdlib as well)
Member
Author
There was a problem hiding this comment.
Nice one, but I'm not sure we should change the order of how subscriptions are defined in the spec, as I would expected CloudQuery to sync those in order (bound to concurrency limits)
Contributor
|
Do we want to ensure the same thing on other plugins? (e.g., AWS, GCP) |
Member
Author
I think it's worth verifying it |
hermanschaaf
approved these changes
Feb 15, 2023
disq
approved these changes
Feb 15, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](plugins-source-azure-v4.1.1...plugins-source-azure-v4.2.0) (2023-02-21) ### Features * **azure:** Add network ExpressRoute circuit authorizations and peerings ([#8128](#8128)) ([2d4cba5](2d4cba5)), closes [#7927](#7927) * **azure:** Add network: interface_ip_configurations and virtual_network_subnets ([#8126](#8126)) ([df5e48b](df5e48b)), closes [#7929](#7929) * **azure:** Add postgresql databases resource ([#8125](#8125)) ([91cab61](91cab61)), closes [#7928](#7928) ### Bug Fixes * **azure:** Ensure spec subscriptions are unique ([#8099](#8099)) ([20dc235](20dc235)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.38.2 ([#8156](#8156)) ([ac2d2d7](ac2d2d7)) * **deps:** Update module golang.org/x/net to v0.7.0 [SECURITY] ([#8176](#8176)) ([fc4cef8](fc4cef8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Feb 26, 2023
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Mar 2, 2023
Related to #713. This PR detects duplicated client IDs, sends a sentry report when that happens and also logs a warning. It not this does not skip those clients (yet). I'll do a follow up based on the sentry data as we can have duplicate clients due to: 1. User errors creating a configuration that generates duplicated clients like in cloudquery/cloudquery#8099 2. Plugins bug, not implementing the ID method correctly ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/cloudquery/cloudquery-issues/issues/491 (internal issue)
Fixes https://github.com/cloudquery/cloudquery-issues/issues/492 (internal issue)
After looking at the data and sample responses:
https://learn.microsoft.com/en-us/rest/api/firewall/azure-firewall-fqdn-tags/list-all?tabs=HTTP
https://learn.microsoft.com/en-us/rest/api/expressroute/express-route-service-providers/list?tabs=HTTP#expressrouteserviceprovider, I think the PKs for these tables are configured correctly
(subscription_id,id)and can't cause duplicates as far as I can tell.However I was able to reproduce the issue by specifying a duplicate subscription in the config, for example: