fix(azure-resources): Make Monitor Diagnostic Settings a relation of generic resources #7943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
yevgenypats
approved these changes
Feb 23, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
🤖 I have created a release *beep* *boop* --- ## [4.3.0](plugins-source-azure-v4.2.0...plugins-source-azure-v4.3.0) (2023-02-28) ### Features * **azure-resources:** Add AKS Upgrade Profile ([#8444](#8444)) ([a665f4b](a665f4b)) * **azure-resources:** Add Management Groups ([#8226](#8226)) ([20a4c0b](20a4c0b)) * **azure-resources:** Add SQL Server Security Alert Policies ([#7939](#7939)) ([210cf81](210cf81)) * **azure-spec:** Add cloud name configuration ([#8471](#8471)) ([d2ec0cc](d2ec0cc)) ### Bug Fixes * **azure-resources:** Make Monitor Diagnostic Settings a relation of generic resources ([#7943](#7943)) ([8316b87](8316b87)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.39.0 ([#8344](#8344)) ([9c57544](9c57544)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.39.1 ([#8371](#8371)) ([e3274c1](e3274c1)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.40.0 ([#8401](#8401)) ([4cf36d6](4cf36d6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #7785. Syncing
azure_monitor_diagnostic_settingsis super slow as it goes through each resource and sends a request to get the diagnostic setting sequentially.While this requires adding a new top level table, I think making diagnostic settings a relation of a generic resources table is more consistent with the rest of the plugins if we want to have concurrency.
Not a breaking change as referencing
azure_monitor_diagnostic_settingsshould still work as before