fix: Postgresql timestamps #7840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because underlyting postgresql type is `timestamp without timezone`, we need to change it to UTC (otherwise we jsut strip TZ information, making the data bad).
yevgenypats
approved these changes
Feb 9, 2023
disq
approved these changes
Feb 9, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
🤖 I have created a release *beep* *boop* --- ## [2.1.0](plugins-destination-postgresql-v2.0.10...plugins-destination-postgresql-v2.1.0) (2023-02-16) ### Features * **pg:** Faster migrations ([#7819](#7819)) ([8f51733](8f51733)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.36.0 ([#7809](#7809)) ([c85a9cb](c85a9cb)) * Postgresql timestamps ([#7840](#7840)) ([e2c8b61](e2c8b61)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because underlyting postgresql type is
timestamp without timezone, we need to change it to UTC (otherwise we jsut strip TZ information, making the data bad).Summary