fix(snowflake): Strip nulls #7836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way writing to snowflake works (i.e. via a JSON file), for text arrays, strings with nulls become screwed up a little (which fails our tests..). ["abc", "def\x00"] becomes, in snowflake, [`abc`, `def\u0000`] i.e. a string of length 4 becomes a string of length 9). This fix does exactly the same thing we do in postgresql.
yevgenypats
approved these changes
Feb 9, 2023
erezrokah
pushed a commit
that referenced
this pull request
Feb 14, 2023
🤖 I have created a release *beep* *boop* --- ## [1.1.11](plugins-destination-snowflake-v1.1.10...plugins-destination-snowflake-v1.1.11) (2023-02-14) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.36.0 ([#7809](#7809)) ([c85a9cb](c85a9cb)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.37.0 ([#7933](#7933)) ([dc9cffb](dc9cffb)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.37.1 ([#8008](#8008)) ([c47aac0](c47aac0)) * Snowflake migration ([#7833](#7833)) ([e738bdd](e738bdd)) * Snowflake migrations ([#7844](#7844)) ([26f65bc](26f65bc)) * **snowflake:** Strip nulls ([#7836](#7836)) ([b5b02b0](b5b02b0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way writing to snowflake works (i.e. via a JSON file), for text arrays, strings with nulls become screwed up a little (which fails our tests..).
["abc", "def\x00"] becomes, in snowflake, [
abc,def\u0000] i.e. a string of length 4 becomes a string of length 9).This fix does exactly the same thing we do in postgresql.