fix(azure): Fix detecting logic for CIS Azure Benchmark v1.3.0 - 2.12 #7807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruneko
changed the title
erezrokah
approved these changes
Feb 8, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.1](plugins-source-azure-v4.1.0...plugins-source-azure-v4.1.1) (2023-02-14) ### Bug Fixes * **azure:** Fix detecting logic for CIS Azure Benchmark v1.3.0 - 2.12 ([#7807](#7807)) ([56b7ee2](56b7ee2)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.36.0 ([#7809](#7809)) ([c85a9cb](c85a9cb)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.36.1 ([#7930](#7930)) ([39dccc1](39dccc1)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.37.0 ([#7933](#7933)) ([dc9cffb](dc9cffb)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.37.1 ([#8008](#8008)) ([c47aac0](c47aac0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found a bug in the logic of CIS Azure Benchmark v1.3.0 Section 2.12 (
policy_assignment_parameters.sqlanddefault_policy_disabled.sql).The current query takes json keys in the
propertycolumn of theazure_policy_assignmentstable to make a view. But, an actual value of the column is below.{ "scope": "/subscriptions/cc9a41f6-4e32-4f28-8326-a3c49e7036a3", "metadata": { "createdBy": "ae1999e6-b000-4f94-8e1c-ece7b864e35b", "createdOn": "2022-08-19T01:36:48.5129096Z", "updatedBy": "64fd25ee-36e3-44e9-bf7a-96e411ae909f", "updatedOn": "2023-02-08T03:00:27.2551198Z", "assignedBy": "Security Center", "parameterScopes": {}, "excludedOutOfTheBoxStandards": [ "PCI DSS 3.2.1", "ISO 27001", "SOC TSP" ] }, "notScopes": [], "parameters": { "sqlServerAuditingMonitoringEffect": { "value": "Disabled" }, "adaptiveApplicationControlsUpdateMonitoringEffect": { "value": "Disabled" } }, "description": "This is the default set of policies monitored by Azure Security Center. It was automatically assigned as part of onboarding to Security Center. The default assignment contains only audit policies. For more information please visit https://aka.ms/ascpolicies", "displayName": "ASC Default (subscription: cc9a41f6-4e32-4f28-8326-a3c49e7036a3)", "enforcementMode": "Default", "policyDefinitionId": "/providers/Microsoft.Authorization/policySetDefinitions/1f3afdf9-d0c9-4c3d-847f-89da613e70a8", "nonComplianceMessages": [] }Therefore, the result of taking keys is always the array
[scope, metadata, notStopes, parameters, description, displayName, enforcementMode, policyDefinitionId]. It is useless for checking the condition in the rule. The correct logic is taking json keys in theparametersfield.And then, when the policy sql writes in the result table, it only saves the
idcolumn on the table. But theidis always same among the result. We cannot identify which policies are disabled. That's way, I concatedidandparamfiled with/to do that.