feat(gcp-resources): Add Compute Routers and NAT Mappings #7691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Feb 6, 2023
| | ------------- | ------------- | | ||
| |_cq_source_name|String| | ||
| |_cq_sync_time|Timestamp| | ||
| |_cq_id (PK)|UUID| |
Member
Author
There was a problem hiding this comment.
Could not find a good PK to set here
This PR has the following changes to source plugin(s) tables:
|
erezrokah
commented
Feb 6, 2023
| } | ||
|
|
||
| if err != nil { | ||
| if strings.Contains(err.Error(), "No Nat mapping information is available in the given router.") { |
Member
Author
There was a problem hiding this comment.
I'm not sure if we should report this or not. Seems like this error is expected when there are no mappings so not sure we should fail
yevgenypats
approved these changes
Feb 7, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ## [7.5.0](plugins-source-gcp-v7.4.0...plugins-source-gcp-v7.5.0) (2023-02-07) ### Features * **gcp-resources:** Add Compute Routers and NAT Mappings ([#7691](#7691)) ([73c653e](73c653e)) ### Bug Fixes * **deps:** Update github.com/cncf/udpa/go digest to c52dc94 ([#7526](#7526)) ([2c31906](2c31906)) * **deps:** Update github.com/cncf/xds/go digest to 46e39c7 ([#7527](#7527)) ([9e94369](9e94369)) * **deps:** Update golang.org/x/exp digest to f062dba ([#7531](#7531)) ([59d5575](59d5575)) * **deps:** Update google.golang.org/genproto digest to 1c01626 ([#7533](#7533)) ([c549c27](c549c27)) * **deps:** Update module cloud.google.com/go to v0.109.0 ([#7584](#7584)) ([f95de44](f95de44)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.33.0 ([#7595](#7595)) ([c5adc75](c5adc75)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.33.1 ([#7614](#7614)) ([2fe665c](2fe665c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.34.0 ([#7719](#7719)) ([6a33085](6a33085)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7684