feat(azure-resources): Add Virtual Network Gateways and Connections #7636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
erezrokah
commented
Feb 2, 2023
| logger zerolog.Logger | ||
| registeredNamespaces map[string]map[string]bool | ||
| resourceGroups map[string][]*armresources.GenericResourceExpanded | ||
| resourceGroups map[string][]string |
Member
Author
There was a problem hiding this comment.
We only need the group names, no reason to keep the whole object
erezrokah
commented
Feb 2, 2023
|
|
||
| func (c *Client) disocverResourceGroups(ctx context.Context) error { | ||
| c.resourceGroups = make(map[string][]*armresources.GenericResourceExpanded, len(c.subscriptions)) | ||
| filter := "resourceType eq 'Microsoft.Resources/resourceGroups'" |
Member
Author
There was a problem hiding this comment.
This query wasn't working (returned 0 results). There's a dedicated client to get the resource groups so I used that one
erezrokah
commented
Feb 2, 2023
|
|
||
| func (c *Client) ID() string { | ||
| return c.SubscriptionId | ||
| if c.ResourceGroup != "" { |
Member
Author
There was a problem hiding this comment.
Follows the Azure convention, see
erezrokah
commented
Feb 2, 2023
| client := meta.(*Client) | ||
| var c = make([]schema.ClientMeta, 0) | ||
| for _, subId := range client.subscriptions { | ||
| if _, ok := client.registeredNamespaces[subId][namespace]; ok { |
Member
Author
There was a problem hiding this comment.
Kept the logic as SubscriptionMultiplexRegisteredNamespace to skip non registered namespaces
erezrokah
commented
Feb 2, 2023
| return err | ||
| } | ||
|
|
||
| pager := svc.NewListPager(cl.ResourceGroup, nil) |
Member
Author
There was a problem hiding this comment.
See here that we only pass the resource group unlike other resources that pass other parent's fields
erezrokah
commented
Feb 2, 2023
| return err | ||
| } | ||
|
|
||
| pager := svc.NewListPager(cl.ResourceGroup, nil) |
Member
Author
There was a problem hiding this comment.
See here that we only pass the resource group unlike other resources that pass other parent's fields
yevgenypats
approved these changes
Feb 7, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.0](plugins-source-azure-v4.0.0...plugins-source-azure-v4.1.0) (2023-02-07) ### Features * **azure-resources:** Add Virtual Network Gateways and Connections ([#7636](#7636)) ([97a9254](97a9254)) ### Bug Fixes * **azure-resources:** Use default API version of `armhealthbot` bots client ([#7177](#7177)) ([e24af94](e24af94)) * **azure:** Fix Azure CIS Policies in Section 2 ([#7718](#7718)) ([3c77b2c](3c77b2c)) * **deps:** Update golang.org/x/exp digest to f062dba ([#7531](#7531)) ([59d5575](59d5575)) * **deps:** Update google.golang.org/genproto digest to 1c01626 ([#7533](#7533)) ([c549c27](c549c27)) * **deps:** Update module github.com/Azure/azure-sdk-for-go/sdk/azidentity to v1.2.1 ([#7540](#7540)) ([3b5c838](3b5c838)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.33.0 ([#7595](#7595)) ([c5adc75](c5adc75)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.33.1 ([#7614](#7614)) ([2fe665c](2fe665c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.34.0 ([#7719](#7719)) ([6a33085](6a33085)) * **deps:** Update module github.com/golang-jwt/jwt/v4 to v4.4.3 ([#7543](#7543)) ([0607454](0607454)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7628.
Notes
cloudquery/plugins/source/azure/resources/services/appservice/web_app_vnet_connections.go
Line 30 in 8d97115