fix(aws): Update EC2 Tag structure #7621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
disq
approved these changes
Feb 1, 2023
Member
|
Hmm, I assume this was a regression - how did it happen? Was it during the transformer refactor? |
hermanschaaf
approved these changes
Feb 1, 2023
Collaborator
Author
Yeah it was during the transformer refactor... I am trying to figure out how I can verify that this was in fact the only miss... Any ideas? |
Member
|
@bbernays I think we pretty much have to look for all |
5 tasks
Contributor
|
Could we also add a resolver transformer that will check if the fields is a JSON field, and, in that case, verify that we're dealing with tags in form of kv pairs slice? This way it'll apply to all proper fields and we would need to do this fix once. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
🤖 I have created a release *beep* *boop* --- ## [13.1.0](plugins-source-aws-v13.0.0...plugins-source-aws-v13.1.0) (2023-02-06) ### Features * **aws-resources:** Add EC2 EBS Volume Statuses ([#7638](#7638)) ([a23c6a3](a23c6a3)) ### Bug Fixes * **aws:** Turn tags into maps ([#7678](#7678)) ([acaa654](acaa654)) * **aws:** Update EC2 Tag structure ([#7621](#7621)) ([8d97115](8d97115)) * **deps:** Update module github.com/aws/aws-sdk-go-v2 to v1.17.4 ([#7652](#7652)) ([2196050](2196050)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.12 ([#7653](#7653)) ([59daf42](59daf42)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/ec2/imds to v1.12.22 ([#7655](#7655)) ([4e56621](4e56621)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.51 ([#7656](#7656)) ([43a0c59](43a0c59)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/internal/ini to v1.3.29 ([#7659](#7659)) ([60f15d7](60f15d7)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/internal/v4a to v1.0.19 ([#7660](#7660)) ([9035012](9035012)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/accessanalyzer to v1.19.2 ([#7661](#7661)) ([dfbb566](dfbb566)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/account to v1.8.1 ([#7662](#7662)) ([ceebda7](ceebda7)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/acm to v1.17.2 ([#7663](#7663)) ([0d29d75](0d29d75)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/amp to v1.16.1 ([#7664](#7664)) ([72e3613](72e3613)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigateway to v1.16.2 ([#7665](#7665)) ([a84fd09](a84fd09)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigatewayv2 to v1.13.2 ([#7666](#7666)) ([335fb4f](335fb4f)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/applicationautoscaling to v1.17.2 ([#7667](#7667)) ([be3e871](be3e871)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apprunner to v1.16.1 ([#7668](#7668)) ([01aa892](01aa892)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/athena to v1.22.1 ([#7669](#7669)) ([dbfdb6d](dbfdb6d)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/autoscaling to v1.26.2 ([#7670](#7670)) ([8e1dc76](8e1dc76)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/backup to v1.19.2 ([#7671](#7671)) ([36e1ea5](36e1ea5)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudfront to v1.24.1 ([#7672](#7672)) ([9a246a2](9a246a2)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudhsmv2 to v1.14.1 ([#7673](#7673)) ([63c0e33](63c0e33)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatch to v1.25.2 ([#7674](#7674)) ([88d2b93](88d2b93)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v1.20.2 ([#7675](#7675)) ([4b04056](4b04056)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/codebuild to v1.20.2 ([#7676](#7676)) ([c0d4e3c](c0d4e3c)) * Update endpoints ([#7626](#7626)) ([91cf8ad](91cf8ad)) * Update endpoints ([#7641](#7641)) ([3ceebc6](3ceebc6)) * Update endpoints ([#7648](#7648)) ([dd8c4fe](dd8c4fe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary