Skip to content

Conversation

@erezrokah
Copy link
Member

Summary

Same as #6958 for the file destination

@erezrokah erezrokah requested review from a team, bbernays and yevgenypats and removed request for a team and yevgenypats January 31, 2023 10:29
@erezrokah
Copy link
Member Author

One thing I'm not sure about is if I should create a default file spec as in:

func (s *Spec) SetDefaults() {

It seems it's not needed as the file types client does it.
Also other destinations don't do it:

func (*Spec) SetDefaults() {}

func (s *Spec) SetDefaults() {

@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Jan 31, 2023
@erezrokah erezrokah changed the title feat: Update file destination to latest filetype module feat!: Update file destination to latest filetype module Jan 31, 2023
@erezrokah erezrokah removed the automerge Automatically merge once required checks pass label Jan 31, 2023
@disq disq self-requested a review January 31, 2023 14:42
@erezrokah
Copy link
Member Author

Replaced by #7466

@erezrokah erezrokah closed this Jan 31, 2023
@erezrokah erezrokah deleted the fix/update_destination_file_sdk branch January 31, 2023 14:51
kodiakhq bot pushed a commit that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants