Skip to content

fix(aws)!: PK for aws_apigateway_domain_name_base_path_mappings #7347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 7 commits into from
Jan 30, 2023
Merged

fix(aws)!: PK for aws_apigateway_domain_name_base_path_mappings #7347

kodiakhq merged 7 commits into from
Jan 30, 2023

Conversation

@bbernays
Copy link
Collaborator

@bbernays bbernays commented Jan 30, 2023 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
fix(aws)!: PK for aws_apigateway_domain_name_base_path_mappings
END_COMMIT_OVERRIDE

@bbernays bbernays linked an issue Jan 30, 2023 that may be closed by this pull request
PK for aws_apigateway_domain_name_base_path_mappings #7346
Closed
@cq-bot cq-bot added the aws label Jan 30, 2023
@github-actions
Copy link

github-actions bot commented Jan 30, 2023 •
edited
Loading

This PR has the following changes to source plugin(s) tables:

  • Table aws_apigateway_domain_name_base_path_mappings: primary key constraint added to column account_id
  • Table aws_apigateway_domain_name_base_path_mappings: primary key constraint added to column arn
  • Table aws_apigateway_domain_name_base_path_mappings: primary key constraint removed from column _cq_id

@hermanschaaf
Copy link
Member

hermanschaaf commented Jan 30, 2023

Looking at resolveApigatewayDomainNameBasePathMappingArn, it seems like AccountID is empty, even though we multiplex on account ID. Should we maybe keep account ID and region in the PK as well to be safe? Or do you think, because it's a domain name, it should be unique across accounts? 🤔

@bbernays
Copy link
Collaborator Author

bbernays commented Jan 30, 2023

Looking at resolveApigatewayDomainNameBasePathMappingArn, it seems like AccountID is empty, even though we multiplex on account ID. Should we maybe keep account ID and region in the PK as well to be safe? Or do you think, because it's a domain name, it should be unique across accounts? 🤔

Literally just fixed this haha

@bbernays bbernays added the automerge Automatically merge once required checks pass label Jan 30, 2023
@kodiakhq kodiakhq bot merged commit 8a945be into cloudquery:main Jan 30, 2023
This was referenced Jan 30, 2023
Closed
Closed
@bbernays bbernays changed the title fix(aws): PK for aws_apigateway_domain_name_base_path_mappings fix(aws)!: PK for aws_apigateway_domain_name_base_path_mappings Jan 31, 2023
@cq-bot cq-bot mentioned this pull request Jan 31, 2023
Merged
@bbernays bbernays deleted the basepathmappings-pk branch February 1, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PK for aws_apigateway_domain_name_base_path_mappings

3 participants

@bbernays @hermanschaaf @cq-bot