Skip to content

feat: Add Resilience Hub resources #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 14 commits into from
Feb 6, 2023
Merged

feat: Add Resilience Hub resources #7299

kodiakhq merged 14 commits into from
Feb 6, 2023

Conversation

@amanenk
Copy link
Contributor

@amanenk amanenk commented Jan 28, 2023

Summary

closes #6977

@cq-bot cq-bot added the aws label Jan 28, 2023
@github-actions
Copy link

github-actions bot commented Jan 28, 2023 •
edited
Loading

This PR has the following changes to source plugin(s) tables:

  • Table aws_resiliencehub_alarm_recommendations was added
  • Table aws_resiliencehub_app_assessments was added
  • Table aws_resiliencehub_app_component_compliances was added
  • Table aws_resiliencehub_app_version_resource_mappings was added
  • Table aws_resiliencehub_app_version_resources was added
  • Table aws_resiliencehub_app_versions was added
  • Table aws_resiliencehub_apps was added
  • Table aws_resiliencehub_component_recommendations was added
  • Table aws_resiliencehub_recommendation_templates was added
  • Table aws_resiliencehub_resiliency_policies was added
  • Table aws_resiliencehub_sop_recommendations was added
  • Table aws_resiliencehub_suggested_resiliency_policies was added
  • Table aws_resiliencehub_test_recommendations was added

erezrokah
erezrokah requested changes Jan 29, 2023
View reviewed changes
Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS part looks good, can we move the k8s fixes to a separate PR?

@cq-bot cq-bot added cli and removed hubspot labels Jan 30, 2023
@amanenk amanenk force-pushed the feat/aws-resilience-hub branch from 07ad679 to cc4ab01 Compare January 30, 2023 09:30
@amanenk amanenk marked this pull request as ready for review January 30, 2023 09:31
@amanenk amanenk requested a review from erezrokah January 30, 2023 09:32
disq
disq requested changes Jan 30, 2023
View reviewed changes
@disq
Copy link
Member

disq commented Jan 30, 2023

PhysicalResourceId is hopefully unique but with names and others I'm not so sure.

@disq
Copy link
Member

disq commented Jan 30, 2023

Nice fix, also added PK to arn fields, which could be unneeded... I quickly checked a few resources in aws/ and if the arn is the PK we don't seem to add account_id/region as additional PKs.

@amanenk amanenk requested a review from disq January 30, 2023 15:10
hermanschaaf
hermanschaaf approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably just that one PK that could be simplified a little

@amanenk amanenk requested review from disq and removed request for disq February 1, 2023 20:36
@amanenk amanenk added the automerge Automatically merge once required checks pass label Feb 6, 2023
@kodiakhq kodiakhq bot merged commit 1b54e7e into cloudquery:main Feb 6, 2023
@cq-bot cq-bot mentioned this pull request Feb 6, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Feb 7, 2023
@cq-bot
chore(main): Release plugins-source-aws v13.2.0 (#7690)
0bcec9f 
🤖 I have created a release *beep* *boop*
---


## [13.2.0](plugins-source-aws-v13.1.0...plugins-source-aws-v13.2.0) (2023-02-07)


### Features

* Add Resilience Hub resources ([#7299](#7299)) ([1b54e7e](1b54e7e))
* **aws:** Add support for Amplify Apps ([#7695](#7695)) ([8ee00c5](8ee00c5))
* **aws:** Add support for ECS Tasksets ([#7688](#7688)) ([b77e8b5](b77e8b5))
* **aws:** Add support for EKS Fargate Profiles ([#7693](#7693)) ([1f668db](1f668db))
* **AWS:** Add support for EKS Node Groups ([#7692](#7692)) ([4a5650e](4a5650e))
* **aws:** Add Support for Secrets Manager Secret Versions ([#7701](#7701)) ([041c341](041c341))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.34.0 ([#7719](#7719)) ([6a33085](6a33085))
* Update endpoints ([#7702](#7702)) ([03d1eeb](03d1eeb))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq disq approved these changes

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@erezrokah erezrokah erezrokah approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AWS Resilience Hub

5 participants

@amanenk @disq @hermanschaaf @erezrokah @cq-bot