feat(source-pg): New source postgresql #7297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
disq
reviewed
Jan 30, 2023
|
|
||
| func Configure(ctx context.Context, logger zerolog.Logger, spec specs.Source, _ source.Options) (schema.ClientMeta, error) { | ||
| c := &Client{ | ||
| logger: logger.With().Str("module", "pg-dest").Logger(), |
Member
There was a problem hiding this comment.
Suggested change
| logger: logger.With().Str("module", "pg-dest").Logger(), | |
| logger: logger.With().Str("module", "pg-source").Logger(), |
yevgenypats
force-pushed
the
feat/source_postgresql
branch
from
be56f8c to
1c98f1b
Compare
Contributor
Author
|
Closing in favour of #7297 |
Member
|
You mean #7835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is postgresql soruce in progress