fix(aws): Built in Resolvers #7203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
approved these changes
Jan 26, 2023
Collaborator
Author
I ran into issues with Security Hub where the Region resolver was updating different columns from where it was called. |
erezrokah
approved these changes
Jan 26, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
🤖 I have created a release *beep* *boop* --- ## [12.2.0](plugins-source-aws-v12.1.0...plugins-source-aws-v12.2.0) (2023-01-26) ### Features * **aws:** Add support for Lambda Runtime Management ([#7152](#7152)) ([888e6e2](888e6e2)) ### Bug Fixes * **aws:** Built in Resolvers ([#7203](#7203)) ([6b32744](6b32744)) * **aws:** Cloudtrail pks ([#7199](#7199)) ([06d8ff6](06d8ff6)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.29.0 ([#7121](#7121)) ([b7441c9](b7441c9)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.30.0 ([#7222](#7222)) ([73ca21c](73ca21c)) * Update endpoints ([#7142](#7142)) ([7116865](7116865)) * Update endpoints ([#7198](#7198)) ([506392f](506392f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this fix if a user tried to use
client.ResolveAWSAccounton a column not onaccount_idit would fail because the resolver had the column name hard coded