fix(s3)!: Clean inputs #7116
Merged
fix(s3)!: Clean inputs #7116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
requested review from
a team and
disq
and removed request for
a team
Closed
3 tasks
candiduslynx
approved these changes
Jan 24, 2023
candiduslynx
approved these changes
Jan 24, 2023
disq
approved these changes
Jan 24, 2023
hermanschaaf
requested changes
Jan 25, 2023
Member
hermanschaaf
left a comment
hermanschaaf
left a comment
There was a problem hiding this comment.
Let's make sure {{UUID}} and {{TABLE}} are replaced with something before writing to the tmp file. Maybe {{UUID}} could be just the string uuid and {{TABLE}} could be table, or something like that? Not sure what would be good behavior here that would avoid potential permissions issues
Co-authored-by: candiduslynx <[email protected]>
hermanschaaf
requested changes
Jan 25, 2023
Co-authored-by: Herman Schaaf <[email protected]>
hermanschaaf
approved these changes
Jan 25, 2023
hermanschaaf
approved these changes
Jan 25, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.0](plugins-destination-s3-v1.1.1...plugins-destination-s3-v2.0.0) (2023-01-31) ### ⚠ BREAKING CHANGES * Add ability to override CSV File options (headers and delimiters) ([#6958](#6958)) * **s3:** Clean inputs ([#7116](#7116)) ### Features * Add ability to override CSV File options (headers and delimiters) ([#6958](#6958)) ([d03819c](d03819c)) ### Bug Fixes * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.49 ([#7309](#7309)) ([16da39d](16da39d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.29.0 ([#7121](#7121)) ([b7441c9](b7441c9)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.30.0 ([#7222](#7222)) ([73ca21c](73ca21c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.31.0 ([#7228](#7228)) ([36e8549](36e8549)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.32.0 ([#7334](#7334)) ([b684122](b684122)) * **s3:** Clean inputs ([#7116](#7116)) ([0132fb4](0132fb4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary