fix: Handle NoConnection #14112
Merged
fix: Handle NoConnection #14112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
requested review from
a team and
candiduslynx
and removed request for
a team
disq
approved these changes
Sep 28, 2023
candiduslynx
approved these changes
Sep 28, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.12](plugins-source-firestore-v3.0.11...plugins-source-firestore-v3.0.12) (2023-09-28) ### Bug Fixes * Handle NoConnection ([#14112](#14112)) ([691ddd4](691ddd4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See https://github.com/cloudquery/cloudquery/actions/runs/6328679225/job/17187394279#step:6:89 I missed this in #14102.
If we pass empty tables to
FilterDfsit fails since there are no matches.