fix: Use correct timezones for delete query for Snowflake Destination
#14097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
requested review from
a team and
erezrokah
and removed request for
a team
disq
approved these changes
Sep 27, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
🤖 I have created a release *beep* *boop* --- ## [3.2.4](plugins-destination-snowflake-v3.2.3...plugins-destination-snowflake-v3.2.4) (2023-09-28) ### Bug Fixes * **deps:** Update AWS modules ([#13873](#13873)) ([9d06ede](9d06ede)) * **deps:** Update AWS modules ([#14020](#14020)) ([3cd58a3](3cd58a3)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to ffb7089 ([#13879](#13879)) ([f95ced5](f95ced5)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.10.0 ([#13978](#13978)) ([2efdf55](2efdf55)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.10.2 ([#13988](#13988)) ([aebaddf](aebaddf)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.11.0 ([#14031](#14031)) ([ac7cdc4](ac7cdc4)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.11.1 ([#14063](#14063)) ([5a0ff7b](5a0ff7b)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.8.0 ([#13950](#13950)) ([15b0b69](15b0b69)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.9.0 ([#13960](#13960)) ([f074076](f074076)) * Use correct timezones for `delete` query for Snowflake Destination ([#14097](#14097)) ([91da647](91da647)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
2 tasks
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
…#13875) 🤖 I have created a release *beep* *boop* --- ## [3.2.4](cloudquery/cloudquery@plugins-destination-snowflake-v3.2.3...plugins-destination-snowflake-v3.2.4) (2023-09-28) ### Bug Fixes * **deps:** Update AWS modules ([cloudquery#13873](cloudquery#13873)) ([9d06ede](cloudquery@9d06ede)) * **deps:** Update AWS modules ([cloudquery#14020](cloudquery#14020)) ([3cd58a3](cloudquery@3cd58a3)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to ffb7089 ([cloudquery#13879](cloudquery#13879)) ([f95ced5](cloudquery@f95ced5)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.10.0 ([cloudquery#13978](cloudquery#13978)) ([2efdf55](cloudquery@2efdf55)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.10.2 ([cloudquery#13988](cloudquery#13988)) ([aebaddf](cloudquery@aebaddf)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.11.0 ([cloudquery#14031](cloudquery#14031)) ([ac7cdc4](cloudquery@ac7cdc4)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.11.1 ([cloudquery#14063](cloudquery#14063)) ([5a0ff7b](cloudquery@5a0ff7b)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.8.0 ([cloudquery#13950](cloudquery#13950)) ([15b0b69](cloudquery@15b0b69)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.9.0 ([cloudquery#13960](cloudquery#13960)) ([f074076](cloudquery@f074076)) * Use correct timezones for `delete` query for Snowflake Destination ([cloudquery#14097](cloudquery#14097)) ([91da647](cloudquery@91da647)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems by default Snowflake uses
America/Pacifictimezone or the current session timezone (if it was overridden via the connection string) when using thetimestamp_tzby switching totimestamp_ntzall timestamps will be in UTC