feat: Support plugin kind in CLI publish command #13997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Sep 22, 2023
|
|
||
| cloudquery_api "github.com/cloudquery/cloudquery-api-go" | ||
| "github.com/cloudquery/cloudquery/cli/internal/auth" | ||
| "github.com/cloudquery/plugin-sdk/v4/plugin" |
Member
Author
There was a problem hiding this comment.
The CLI should not reference the SDK, only https://github.com/cloudquery/plugin-pb-go
Member
Author
There was a problem hiding this comment.
Actually I see it's used for the docs command too so we might want to refactor it at some point. The API surface the CLI should interact with is https://github.com/cloudquery/plugin-pb-go
Member
There was a problem hiding this comment.
Yes, we should refactor this at some point. It will mean copying quite a bit of code from the SDK into plugin-pb-go I think, e.g. all the table struct definitions and how to convert from Arrow to that.
erezrokah
commented
Sep 22, 2023
| Name string `json:"name"` | ||
| Message string `json:"message"` | ||
| Version string `json:"version"` | ||
| Kind cloudquery_api.PluginKind `json:"kind"` |
Member
Author
There was a problem hiding this comment.
I could also make it a string or any other wrapper type and convert, but this works as we keep the enums consistent
erezrokah
changed the title
hermanschaaf
approved these changes
Sep 22, 2023
1 task
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
🤖 I have created a release *beep* *boop* --- ## [3.19.0](cli-v3.18.0...cli-v3.19.0) (2023-09-22) ### Features * Support plugin kind in CLI publish command ([#13997](#13997)) ([c2bac9c](c2bac9c)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.10.0 ([#13955](#13955)) ([46ac73d](46ac73d)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.10.0 ([#13978](#13978)) ([2efdf55](2efdf55)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.10.2 ([#13988](#13988)) ([aebaddf](aebaddf)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.9.0 ([#13960](#13960)) ([f074076](f074076)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
added a commit
that referenced
this pull request
Sep 22, 2023
<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> #### Summary Follow up to #13997 <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Run `make lint` to ensure the proposed changes follow the coding style 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Run `make test` to ensure the proposed changes pass the tests 🧪 - [ ] If changing a source plugin run `make gen` to ensure docs are up to date 📝 - [ ] Ensure the status checks below are successful ✅ ---> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #13996. Supports plugin kind in the CLI when publishing plugins