fix: Revert "feat: Update github.com/cloudquery/plugin-sdk/v4 to v4.6.1"
#13589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
requested review from
a team,
candiduslynx,
erezrokah and
mnorbury
and removed request for
a team and
mnorbury
hermanschaaf
changed the title
github.com/cloudquery/plugin-sdk/v4 to v4.6.1"github.com/cloudquery/plugin-sdk/v4 to v4.6.1"
candiduslynx
approved these changes
Sep 1, 2023
hermanschaaf
deleted the
revert-13586-feat/plugin-sdk-4.6.1/elasticsearch
branch
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
🤖 I have created a release *beep* *boop* --- ## [3.1.0](plugins-destination-elasticsearch-v3.0.3...plugins-destination-elasticsearch-v3.1.0) (2023-09-05) ### Features * Bulk all messages in a batch into a single bulk write ([#13588](#13588)) ([d03e09e](d03e09e)) * Update `github.com/cloudquery/plugin-sdk/v4` to `v4.6.1` () ([2ef2597](2ef2597)) ### Bug Fixes * **deps:** Update `github.com/cloudquery/plugin-sdk/v4` to `v4.6.3` ([#13600](#13600)) ([508fce5](508fce5)) * **deps:** Update github.com/99designs/go-keychain digest to 9cf53c8 ([#13561](#13561)) ([a170256](a170256)) * **deps:** Update github.com/apache/arrow/go/v14 digest to a526ba6 ([#13562](#13562)) ([248672b](248672b)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to cd3d411 ([#13598](#13598)) ([f22bfa6](f22bfa6)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.6.4 ([#13519](#13519)) ([9d25165](9d25165)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.7.0 ([#13625](#13625)) ([bb5463f](bb5463f)) * Perform `delete-stale` for the tables with no primary keys, too ([2ef2597](2ef2597)) * Revert "feat: Update `github.com/cloudquery/plugin-sdk/v4` to `v4.6.1`" ([#13589](#13589)) ([f684ab9](f684ab9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13586
Deleting from all indexes matching the
*pattern can have unintended consequences, especially as far as performance is concerned. I think we need to find another solution to the problem of not knowing whether a sync is being done inappendmode oroverwritemode