feat: Update github.com/cloudquery/plugin-sdk/v4 to v4.6.1
#13586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
requested review from
a team,
bbernays and
hermanschaaf
and removed request for
a team
candiduslynx
commented
Sep 1, 2023
| req := deletebyquery.NewRequest() | ||
| req.Query = &q | ||
| return c.deleteStaleIndex(gctx, msg.TableName, req) | ||
| return c.deleteStaleIndex(gctx, msg.TableName+"*", req) |
Contributor
Author
There was a problem hiding this comment.
as we write to a table.Name + "-" + syncTime.Format(tine.DateOnly) for tables with no PK
candiduslynx
commented
Sep 1, 2023
| resp, err := c.client.Bulk(bytes.NewReader(buf.Bytes()), | ||
| c.client.Bulk.WithContext(ctx), | ||
| c.client.Bulk.WithIndex(index), | ||
| c.client.Bulk.WithRefresh("wait_for"), |
Contributor
Author
There was a problem hiding this comment.
required to flush the data before the write returns (either this or we do the refresh before the delete stale)
erezrokah
approved these changes
Sep 1, 2023
hermanschaaf
added a commit
that referenced
this pull request
Sep 1, 2023
…4.6.1`" (#13589) Reverts #13586 Deleting from all indexes matching the `*` pattern can have unintended consequences, especially as far as performance is concerned. I think we need to find another solution to the problem of not knowing whether a sync is being done in `append` mode or `overwrite` mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #13492 & #13553
BEGIN_COMMIT_OVERRIDE
feat: Update
github.com/cloudquery/plugin-sdk/v4tov4.6.1()fix: Perform
delete-stalefor the tables with no primary keys, tooEND_COMMIT_OVERRIDE