fix: Use Pagination for aws_ec2_images
#13560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
approved these changes
Sep 1, 2023
Member
|
Was there an issue attached to this, or just something you noticed? |
hermanschaaf
changed the title
aws_ec2_imagesaws_ec2_images
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
🤖 I have created a release *beep* *boop* --- ## [22.9.0](plugins-source-aws-v22.8.2...plugins-source-aws-v22.9.0) (2023-09-05) ### Features * Add `aws_s3_bucket_notification_configurations` table ([#13608](#13608)) ([d3b08ee](d3b08ee)) * Add `aws_s3_bucket_object_lock_configurations` table ([#13609](#13609)) ([1debcd3](1debcd3)), closes [#13606](#13606) * **services:** Support newly added regions ([#13617](#13617)) ([bb67e06](bb67e06)) ### Bug Fixes * **deps:** Update `github.com/cloudquery/plugin-sdk/v4` to `v4.7.0` ([#13623](#13623)) ([871a792](871a792)) * **deps:** Update github.com/99designs/go-keychain digest to 9cf53c8 ([#13561](#13561)) ([a170256](a170256)) * **deps:** Update github.com/apache/arrow/go/v14 digest to a526ba6 ([#13562](#13562)) ([248672b](248672b)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to cd3d411 ([#13598](#13598)) ([f22bfa6](f22bfa6)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.6.0 ([#13492](#13492)) ([c305876](c305876)) * Don't reference public schema in policies ([#13619](#13619)) ([163aa94](163aa94)) * Use Pagination for `aws_ec2_images` ([#13560](#13560)) ([a3779e8](a3779e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rather than returning all images in a single API call, this PR changes it to use pagination... It will return 1000 images at a time. This will improve performance for large accounts where it is faster to batch the results rather than return them all at once