Skip to content

fix(deps): Update AWS modules #12773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 6 commits into from
Aug 7, 2023
Merged

fix(deps): Update AWS modules #12773

kodiakhq merged 6 commits into from
Aug 7, 2023

Conversation

@cq-bot
Copy link
Contributor

@cq-bot cq-bot commented Aug 5, 2023

This PR contains the following updates:

Package Type Update Change
github.com/aws/aws-sdk-go-v2 require minor v1.19.1 -> v1.20.0
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream indirect patch v1.4.10 -> v1.4.11
github.com/aws/aws-sdk-go-v2/config require patch v1.18.30 -> v1.18.32
github.com/aws/aws-sdk-go-v2/credentials indirect patch v1.13.29 -> v1.13.31
github.com/aws/aws-sdk-go-v2/feature/ec2/imds indirect patch v1.13.6 -> v1.13.7
github.com/aws/aws-sdk-go-v2/feature/s3/manager require patch v1.11.74 -> v1.11.76
github.com/aws/aws-sdk-go-v2/internal/configsources indirect patch v1.1.36 -> v1.1.37
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 indirect patch v2.4.30 -> v2.4.31
github.com/aws/aws-sdk-go-v2/internal/ini indirect patch v1.3.37 -> v1.3.38
github.com/aws/aws-sdk-go-v2/internal/v4a indirect minor v1.0.28 -> v1.1.0
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding indirect patch v1.9.11 -> v1.9.12
github.com/aws/aws-sdk-go-v2/service/internal/checksum indirect patch v1.1.31 -> v1.1.32
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url indirect patch v1.9.30 -> v1.9.31
github.com/aws/aws-sdk-go-v2/service/internal/s3shared indirect minor v1.14.5 -> v1.15.0
github.com/aws/aws-sdk-go-v2/service/s3 require minor v1.37.1 -> v1.38.1
github.com/aws/aws-sdk-go-v2/service/sso indirect minor v1.12.14 -> v1.13.1
github.com/aws/aws-sdk-go-v2/service/ssooidc indirect minor v1.14.14 -> v1.15.1
github.com/aws/aws-sdk-go-v2/service/sts indirect minor v1.20.1 -> v1.21.1
github.com/aws/smithy-go indirect minor v1.13.5 -> v1.14.0

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

Release Notes

aws/aws-sdk-go-v2 (github.com/aws/aws-sdk-go-v2)

v1.20.0

Compare Source

aws/smithy-go (github.com/aws/smithy-go)

v1.14.0

Compare Source

Configuration

📅 Schedule: Branch creation - "before 3am on Saturday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@cq-bot cq-bot added the automerge Automatically merge once required checks pass label Aug 5, 2023
@cq-bot cq-bot added the s3 label Aug 5, 2023
@bbernays bbernays mentioned this pull request Aug 5, 2023
Merged
@bbernays @cq-bot
fix: Replace deprecated method (#12777)
948af58 
<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 -->

#### Summary

#12773 is blocked because the CI won't allow for use of deprecated
methods. So this PR removes the method and replaces it with the new one

---------

Co-authored-by: CloudQuery Bot <[email protected]>
@bbernays bbernays requested a review from a team August 6, 2023 22:53
@cq-bot cq-bot added aws labels Aug 6, 2023
@cq-bot cq-bot removed aws labels Aug 6, 2023
@cq-bot
Copy link
Contributor Author

cq-bot commented Aug 6, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@candiduslynx
Copy link
Contributor

candiduslynx commented Aug 7, 2023

@bbernays I'll update the code to have the method that's missing at the moment (per lint)

@candiduslynx candiduslynx removed the automerge Automatically merge once required checks pass label Aug 7, 2023
@candiduslynx
Copy link
Contributor

candiduslynx commented Aug 7, 2023 •
edited
Loading

@bbernays I've updated the endpoint logic in 5823041.

I removed the automerge label till you take a look. If you're OK with this code just add it back 😃

@erezrokah
Copy link
Member

erezrokah commented Aug 7, 2023

@bbernays I've updated the endpoint login in 5823041.

Maybe we can do the refactoring in a separate PR? That way we don't block this update. af44238 seems pretty straightforward, while 5823041 might require additional testing to validate

@candiduslynx
Copy link
Contributor

candiduslynx commented Aug 7, 2023 •
edited
Loading

af44238 seems pretty straightforward

@erezrokah
The issue is, it doesn't work (there's no such thing in the cfg + the resolve code would change a bit, too (it has to adhere to the s3.EndpointResolverV2 interface that returns absolutely different type endpoints.Endpoint instead the one we're currently returning)).

The code change that just replaces the base endpoint param is the minimal change to have the SDK work properly, though.

@bbernays
Copy link
Collaborator

bbernays commented Aug 7, 2023

I have tested that it works with a local minio server.

@bbernays bbernays added the automerge Automatically merge once required checks pass label Aug 7, 2023
@kodiakhq kodiakhq bot merged commit 1b4376c into main Aug 7, 2023
@kodiakhq kodiakhq bot deleted the renovate/s3-aws-modules branch August 7, 2023 14:51
@cq-bot cq-bot mentioned this pull request Aug 7, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Aug 8, 2023
@cq-bot
chore(main): Release plugins-destination-s3 v4.6.1 (#12589)
a3b05a6 
🤖 I have created a release *beep* *boop*
---


## [4.6.1](plugins-destination-s3-v4.6.0...plugins-destination-s3-v4.6.1) (2023-08-08)


### Bug Fixes

* **deps:** Update AWS modules ([#12587](#12587)) ([f8e1996](f8e1996))
* **deps:** Update AWS modules ([#12773](#12773)) ([1b4376c](1b4376c))
* **deps:** Update github.com/apache/arrow/go/v13 digest to 112f949 ([#12659](#12659)) ([48d73a9](48d73a9))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 3452eb0 ([#12595](#12595)) ([c1c0949](c1c0949))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f53878d ([#12778](#12778)) ([6f5d58e](6f5d58e))
* **deps:** Update module github.com/cloudquery/filetypes/v4 to v4.1.1 ([#12800](#12800)) ([ef33dff](ef33dff))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.4 ([#12718](#12718)) ([f059a15](f059a15))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.5 ([#12731](#12731)) ([d267239](d267239))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.6 ([#12799](#12799)) ([fb0e0d7](fb0e0d7))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

@hermanschaaf hermanschaaf Awaiting requested review from hermanschaaf

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

+1 more reviewer

@candiduslynx candiduslynx candiduslynx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cq-bot @candiduslynx @erezrokah @bbernays @renovate-bot