fix: Return a datadog client instance instead of nil #12766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlindorin
requested review from
a team and
mnorbury
and removed request for
a team
disq
changed the title
Member
|
Oops. Thanks for the fix! |
disq
approved these changes
Aug 4, 2023
candiduslynx
approved these changes
Aug 4, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
🤖 I have created a release *beep* *boop* --- ## [3.1.3](plugins-source-datadog-v3.1.2...plugins-source-datadog-v3.1.3) (2023-08-04) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v13 digest to 112f949 ([#12659](#12659)) ([48d73a9](48d73a9)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 3452eb0 ([#12595](#12595)) ([c1c0949](c1c0949)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.4 ([#12718](#12718)) ([f059a15](f059a15)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.5 ([#12731](#12731)) ([d267239](d267239)) * Return a datadog client instance instead of nil ([#12766](#12766)) ([9d6c354](9d6c354)) * **website:** Move deprecated top level spec options to plugin level ([#12686](#12686)) ([4108210](4108210)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The last versions of Datadog plugin do not work and generate the following message:
The
newClientfunction returnnil,nilif the configuration is good. It should return the client initialized.I wrote also some extra tests to prevent regression.