feat: Replace DelegationSetId with full DelegationSet in aws_route53_hosted_zones #12737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
kfritchman46
changed the title
kfritchman46
changed the title
kfritchman46
changed the title
kfritchman46
changed the title
1 task
erezrokah
requested changes
Aug 3, 2023
Member
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
Thanks for the PR @kfritchman46, can we still keep DelegationSetId? That would make this change non breaking for existing users
Contributor
Author
|
@erezrokah Absolutely, I wasn't sure how strict this project is on clutter vs reducing breaking changes. I'll update. |
kfritchman46
force-pushed
the
add-ds-struct-to-aws-route53-hosted-zone
branch
from
a666161 to
abff4f2
Compare
kfritchman46
changed the title
erezrokah
approved these changes
Aug 7, 2023
Member
Thanks for following up, looks great 🚀 . We try to avoid breaking changes as it requires consumers of the data to drop existing tables in most cases |
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
🤖 I have created a release *beep* *boop* --- ## [22.5.0](plugins-source-aws-v22.4.0...plugins-source-aws-v22.5.0) (2023-08-08) ### This Release has the Following Changes to Tables - Table `aws_rds_cluster_snapshots`: column added with name `db_cluster_resource_id` and type `utf8` - Table `aws_rds_clusters`: column added with name `local_write_forwarding_status` and type `utf8` - Table `aws_rds_engine_versions`: column added with name `supports_local_write_forwarding` and type `bool` - Table `aws_resiliencehub_alarm_recommendations`: column added with name `app_component_names` and type `list<item: utf8, nullable>` - Table `aws_resiliencehub_app_assessments`: column added with name `drift_status` and type `utf8` - Table `aws_resiliencehub_app_assessments`: column added with name `version_name` and type `utf8` - Table `aws_resiliencehub_app_versions`: column added with name `creation_time` and type `timestamp[us, tz=UTC]` - Table `aws_resiliencehub_app_versions`: column added with name `identifier` and type `int64` - Table `aws_resiliencehub_app_versions`: column added with name `version_name` and type `utf8` - Table `aws_resiliencehub_apps`: column added with name `drift_status` and type `utf8` - Table `aws_resiliencehub_apps`: column added with name `event_subscriptions` and type `json` - Table `aws_resiliencehub_apps`: column added with name `last_drift_evaluation_time` and type `timestamp[us, tz=UTC]` - Table `aws_resiliencehub_apps`: column added with name `permission_model` and type `json` - Table `aws_route53_hosted_zones`: column added with name `delegation_set` and type `json` - Table `aws_scheduler_schedules`: column added with name `action_after_completion` and type `utf8` ### Features * Replace DelegationSetId with full DelegationSet in aws_route53_hosted_zones ([#12737](#12737)) ([a78012d](a78012d)) * **services:** Support newly added regions ([#12797](#12797)) ([a64d5a9](a64d5a9)) ### Bug Fixes * **deps:** Update AWS modules ([#12775](#12775)) ([945d570](945d570)) * **deps:** Update AWS modules ([#12776](#12776)) ([91148ac](91148ac)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f53878d ([#12778](#12778)) ([6f5d58e](6f5d58e)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.4 ([#12718](#12718)) ([f059a15](f059a15)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.5 ([#12731](#12731)) ([d267239](d267239)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.6 ([#12799](#12799)) ([fb0e0d7](fb0e0d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default (not reusable) DelegationSet of AWS public HostedZones are only visible when describing the HostedZone. The DelegationSet API doesn't include them. Sync should include the DelegationSet as a json field of the
aws_route53_hosted_zonestable so changes in Nameservers can be detected.