fix(website): Move deprecated top level spec options to plugin level #12686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Aug 1, 2023
| name: firestore | ||
| path: cloudquery/firestore | ||
| version: "VERSION_SOURCE_FIRESTORE" | ||
| concurrency: 10000 |
Member
Author
There was a problem hiding this comment.
Not supported in Firestore (like most other DB sources)
erezrokah
commented
Aug 1, 2023
| name: "mysql" | ||
| path: "cloudquery/mysql" | ||
| version: "VERSION_SOURCE_MYSQL" | ||
| concurrency: 10000 |
Member
Author
There was a problem hiding this comment.
Not supported in MySQL (like most other DB sources)
erezrokah
commented
Aug 1, 2023
| name: "oracledb" | ||
| path: "cloudquery/oracledb" | ||
| version: "VERSION_SOURCE_ORACLEDB" | ||
| concurrency: 10000 |
Member
Author
There was a problem hiding this comment.
Supported in OracleDB source but the default of 100 should be good for now unless someone reports it
hermanschaaf
reviewed
Aug 1, 2023
hermanschaaf
reviewed
Aug 1, 2023
hermanschaaf
reviewed
Aug 1, 2023
erezrokah
force-pushed
the
docs/source_plugin_spec
branch
from
24aa476 to
6752a46
Compare
erezrokah
commented
Aug 2, 2023
| } | ||
|
|
||
| func (s *Spec) SetDefaults() { | ||
| if s.Concurrency == 0 { |
Member
Author
There was a problem hiding this comment.
The default was missing from this plugin
erezrokah
commented
Aug 2, 2023
|
|
||
| const ( | ||
| defaultConccurency = 10000 | ||
| defaultConcurrency = 10000 |
erezrokah
commented
Aug 2, 2023
|
|
||
| func (s *Spec) SetDefaults() { | ||
| if s.Concurrency == 0 { | ||
| s.Concurrency = 10000 |
Member
Author
|
OK so I went through each plugin's implementation and updated the docs for each plugin with the relevant I also removed the |
hermanschaaf
approved these changes
Aug 2, 2023
This was referenced Aug 2, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
🤖 I have created a release *beep* *boop* --- ## [3.1.3](plugins-source-datadog-v3.1.2...plugins-source-datadog-v3.1.3) (2023-08-04) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v13 digest to 112f949 ([#12659](#12659)) ([48d73a9](48d73a9)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 3452eb0 ([#12595](#12595)) ([c1c0949](c1c0949)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.4 ([#12718](#12718)) ([f059a15](f059a15)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.5 ([#12731](#12731)) ([d267239](d267239)) * Return a datadog client instance instead of nil ([#12766](#12766)) ([9d6c354](9d6c354)) * **website:** Move deprecated top level spec options to plugin level ([#12686](#12686)) ([4108210](4108210)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.3](plugins-source-cloudflare-v5.0.2...plugins-source-cloudflare-v5.0.3) (2023-08-08) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v13 digest to 112f949 ([#12659](#12659)) ([48d73a9](48d73a9)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 3452eb0 ([#12595](#12595)) ([c1c0949](c1c0949)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f53878d ([#12778](#12778)) ([6f5d58e](6f5d58e)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.4 ([#12718](#12718)) ([f059a15](f059a15)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.5 ([#12731](#12731)) ([d267239](d267239)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.6 ([#12799](#12799)) ([fb0e0d7](fb0e0d7)) * **website:** Move deprecated top level spec options to plugin level ([#12686](#12686)) ([4108210](4108210)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.3](plugins-source-alicloud-v4.0.2...plugins-source-alicloud-v4.0.3) (2023-08-08) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v13 digest to 112f949 ([#12659](#12659)) ([48d73a9](48d73a9)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 3452eb0 ([#12595](#12595)) ([c1c0949](c1c0949)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f53878d ([#12778](#12778)) ([6f5d58e](6f5d58e)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.4 ([#12718](#12718)) ([f059a15](f059a15)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.5 ([#12731](#12731)) ([d267239](d267239)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.6 ([#12799](#12799)) ([fb0e0d7](fb0e0d7)) * **website:** Move deprecated top level spec options to plugin level ([#12686](#12686)) ([4108210](4108210)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12674 + destinations options + some indentation fixes.
I chose to keep the options on the same page and only move them to the bottom.
This way links to the options don't break.
We should also add the specific options to each plugin, but that's more time consuming