Skip to content

Conversation

@disq
Copy link
Member

@disq disq commented Jul 26, 2023

Fixes #12404

Adds gcp_resourcemanager_subfolders table to allow easy skipping of lower level folders.

@disq disq requested a review from yevgenypats as a code owner July 26, 2023 16:05
@github-actions
Copy link

This PR has the following changes to source plugin(s) tables:

  • Table gcp_resourcemanager_subfolders was added

Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the requirement is to list one level down, or recursively all levels

Ah, noticed the recursion now

@disq disq changed the title feat(gcp-resources): Fetch lower level folders feat(resources): Fetch lower level folders Jul 26, 2023
@disq disq added the automerge Automatically merge once required checks pass label Jul 27, 2023
@kodiakhq kodiakhq bot merged commit 431e95f into cloudquery:main Jul 27, 2023
@disq disq deleted the feat/gcp-subfolders branch July 27, 2023 18:05
kodiakhq bot pushed a commit that referenced this pull request Aug 1, 2023
🤖 I have created a release *beep* *boop*
---


## [9.4.0](plugins-source-gcp-v9.3.4...plugins-source-gcp-v9.4.0) (2023-08-01)


### This Release has the Following Changes to Tables
- Table `gcp_resourcemanager_subfolders` was added

### Features

* **resources:** Fetch lower level folders ([#12539](#12539)) ([431e95f](431e95f))


### Bug Fixes

* **deps:** Update github.com/apache/arrow/go/v13 digest to 112f949 ([#12659](#12659)) ([48d73a9](48d73a9))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 3452eb0 ([#12595](#12595)) ([c1c0949](c1c0949))
* **deps:** Update github.com/cockroachdb/cockroachdb-parser digest to 302c9ad ([#12664](#12664)) ([924509c](924509c))
* **deps:** Update github.com/petermattis/goid digest to 80aa455 ([#12669](#12669)) ([a140396](a140396))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug (GCP): gcp_resourcemanager_folders is only collecting top level folders

3 participants