feat(resources): Add additional emr resources for studio and studio session mapping #12529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
mnorbury
force-pushed
the
mnorbury-adding-emr-resources
branch
from
008a937 to
b024174
Compare
disq
reviewed
Jul 26, 2023
Member
disq
left a comment
disq
left a comment
There was a problem hiding this comment.
Good work! Few comments + I think both tables also need primary keys of some sort, if possible
plugins/source/aws/resources/services/emr/studio_session_mapping.go
Outdated
Show resolved
Hide resolved
mnorbury
force-pushed
the
mnorbury-adding-emr-resources
branch
from
9774cce to
cf35b53
Compare
bbernays
reviewed
Jul 26, 2023
Collaborator
bbernays
left a comment
bbernays
left a comment
There was a problem hiding this comment.
This looks really good! The only thing that I think is missing is running the make gen-docs to generate the table documentation for the new resources
bbernays
reviewed
Jul 26, 2023
bbernays
previously requested changes
Jul 26, 2023
plugins/source/aws/resources/services/emr/studio_session_mapping.go
Outdated
Show resolved
Hide resolved
mnorbury
force-pushed
the
mnorbury-adding-emr-resources
branch
from
ccb9458 to
bbc2805
Compare
bbernays
reviewed
Jul 26, 2023
bbernays
changed the title
mnorbury
force-pushed
the
mnorbury-adding-emr-resources
branch
from
4640109 to
4236723
Compare
bbernays
requested changes
Jul 27, 2023
plugins/source/aws/resources/services/emr/studio_session_mapping.go
Outdated
Show resolved
Hide resolved
- Correcting documention link for `aws_emr_studio_session_mapping` - Adding region and account ID to `aws_emr_studio_session_mapping` - Setting `aws_emr_studio_session_mapping` PK to composite of `StudioId`, `IdentityType`, `IdentityId`, `region` and `account_id` - Setting `aws_emr_studios` PK to `StudioId`
Co-authored-by: bbernays <[email protected]>
mnorbury
force-pushed
the
mnorbury-adding-emr-resources
branch
from
6023ef3 to
85d8ab1
Compare
Co-authored-by: bbernays <[email protected]>
mnorbury
force-pushed
the
mnorbury-adding-emr-resources
branch
from
85d8ab1 to
548c7a6
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
🤖 I have created a release *beep* *boop* --- ## [22.2.0](plugins-source-aws-v22.1.0...plugins-source-aws-v22.2.0) (2023-07-27) ### This Release has the Following Changes to Tables - Table `aws_cloudformation_stack_instance_resource_drifts` was added - Table `aws_cloudformation_stack_instance_summaries` was added - Table `aws_emr_studio_session_mappings` was added - Table `aws_emr_studios` was added - Table `aws_route53recoverycontrolconfig_clusters` was added - Table `aws_route53recoverycontrolconfig_control_panels` was added - Table `aws_route53recoverycontrolconfig_routing_controls` was added - Table `aws_route53recoverycontrolconfig_safety_rules` was added - Table `aws_route53recoveryreadiness_cells` was added - Table `aws_route53recoveryreadiness_readiness_checks` was added - Table `aws_route53recoveryreadiness_recovery_groups` was added - Table `aws_route53recoveryreadiness_resource_sets` was added - Table `aws_s3_multi_region_access_points` was added ### Features * **resources-s3:** Add support for S3 Multi Region Access Points ([#12525](#12525)) ([00c6a3f](00c6a3f)) * **resources:** Add additional emr resources for studio and studio session mapping ([#12529](#12529)) ([66a20a5](66a20a5)) * **resources:** Add Support for Amazon Route 53 ARC Recovery Control Configuration ([#12460](#12460)) ([8c3109b](8c3109b)) * **resources:** Add Support for Cloudformation Stack Instance Summaries and Stack Instance Resource Drifts ([#12495](#12495)) ([e1d9a74](e1d9a74)), closes [#12461](#12461) * **resources:** Add Support for Route53 ARC Recovery Readiness ([#12459](#12459)) ([7d6d4c0](7d6d4c0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #12528