fix: Don't create duplicate columns for unique constraints #12518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
requested review from
a team and
mnorbury
and removed request for
a team
2 tasks
Member
Author
|
See #12440 (comment) for a table that reproduces the issue |
Member
|
Tricky, nice find! Would it be feasible / easy to add a test case for this you think? |
Member
Author
Good point, added a test in 8b4e25c (fixed the lint warnings in a separate commit) |
erezrokah
commented
Jul 25, 2023
| t.Fatalf("expected record to have %d columns, got %d", len(expected), actualRecord.NumCols()) | ||
| } | ||
| schema := actualRecord.Schema() | ||
| sc := actualRecord.Schema() |
Member
Author
There was a problem hiding this comment.
Needed to prevent shadowing the new import "github.com/cloudquery/plugin-sdk/v4/schema"
hermanschaaf
approved these changes
Jul 25, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.3](plugins-source-postgresql-v2.0.2...plugins-source-postgresql-v2.0.3) (2023-07-25) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#12443](#12443)) ([e385283](e385283)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.3 ([#12307](#12307)) ([8f14e4d](8f14e4d)) * Don't create duplicate columns for unique constraints ([#12518](#12518)) ([99e7ad9](99e7ad9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12440
We can't use
likeotherwise an ordinal of1matches bothindkey = 11andindkey = 1