Skip to content

Conversation

@code-vise
Copy link
Contributor

Summary

@code-vise code-vise requested review from a team and disq and removed request for a team July 21, 2023 14:44
@github-actions
Copy link

github-actions bot commented Jul 21, 2023

This PR has the following changes to source plugin(s) tables:

  • Table digitalocean_kubernetes_clusters was added

Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @code-vise. Looks like there are some syntax errors in client.go.
Do you mind fixing them?

@erezrokah erezrokah changed the title feat(Resources): Add DigitalOcean Kubernetes Clusters table feat(resources): Add DigitalOcean Kubernetes Clusters table Jul 25, 2023
@code-vise
Copy link
Contributor Author

Thanks for the PR @code-vise. Looks like there are some syntax errors in client.go. Do you mind fixing them?

Sure

@erezrokah
Copy link
Member

Thanks for the follow up @code-vise. I added another commit to fix some other issues with the linting and tests

@erezrokah erezrokah force-pushed the feat/do_kubernetes_clusters branch from dc15e99 to 4dde882 Compare July 25, 2023 09:03
@code-vise
Copy link
Contributor Author

Thanks for the follow up @code-vise. I added another commit to fix some other issues with the linting and tests

Great. Also to bring this to your knowledge, I read the contribution guide file and I couldn't make this work go generate client/services.go
I'm not sure if documentation is up to date or Im doing something wrong.

@erezrokah
Copy link
Member

I also moved this resource to a new kubernetes directory, so we can add more resources, like ListNodePools

@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Jul 25, 2023
@kodiakhq kodiakhq bot merged commit 95dcaa6 into cloudquery:main Jul 25, 2023
kodiakhq bot pushed a commit that referenced this pull request Jul 25, 2023
🤖 I have created a release *beep* *boop*
---


## [5.2.0](plugins-source-digitalocean-v5.1.1...plugins-source-digitalocean-v5.2.0) (2023-07-25)


### This Release has the Following Changes to Tables
- Table `digitalocean_kubernetes_clusters` was added

### Features

* **resources:** Add DigitalOcean Kubernetes Clusters table ([#12438](#12438)) ([95dcaa6](95dcaa6))


### Bug Fixes

* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#12443](#12443)) ([e385283](e385283))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.3 ([#12307](#12307)) ([8f14e4d](8f14e4d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants