feat(azure): Add private dns record sets and vnet links #12417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
yvardhineni
changed the title
yvardhineni
changed the title
erezrokah
reviewed
Jul 20, 2023
Member
There was a problem hiding this comment.
Thanks for the contribution @yvardhineni 🚀 Looks great.
Added a few comments regarding the table names. We usually include the parent table name (in singular) in the child's name, see example https://github.com/cloudquery/cloudquery/pull/12410/files#diff-d891ecd9395ed7888be8d30554ec319423e7b4821ca871b81235496fab2a5045R14.
This makes it easier to understand the relation from looking at the name.
Please let me know what you think
plugins/source/azure/resources/services/privatedns/record_sets.go
Outdated
Show resolved
Hide resolved
plugins/source/azure/resources/services/privatedns/record_sets.go
Outdated
Show resolved
Hide resolved
plugins/source/azure/resources/services/privatedns/virtual_network_links.go
Outdated
Show resolved
Hide resolved
plugins/source/azure/resources/services/privatedns/virtual_network_links.go
Outdated
Show resolved
Hide resolved
yvardhineni
force-pushed
the
feat/azure_private_dns_record_sets_and_vnet_links
branch
from
4c098c4 to
19d4947
Compare
Contributor
Author
|
Agreed, some convention always help |
erezrokah
approved these changes
Jul 21, 2023
Member
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
Thanks for the follow up @yvardhineni, look great 🎸
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [9.1.0](plugins-source-azure-v9.0.3...plugins-source-azure-v9.1.0) (2023-07-25) ### This Release has the Following Changes to Tables - Table `azure_mysql_server_databases` was added - Table `azure_network_private_endpoints` was added - Table `azure_privatedns_private_zone_record_sets` was added - Table `azure_privatedns_private_zone_virtual_network_links` was added - Table `azure_trafficmanager_profiles` was added ### Features * **azure:** Add azure private endpoints ([#12473](#12473)) ([24d111c](24d111c)) * **azure:** Add azure trafficmanager profiles ([#12458](#12458)) ([347b5c5](347b5c5)) * **azure:** Add private dns record sets and vnet links ([#12417](#12417)) ([2f337b1](2f337b1)) * **resources:** Add MySQL Server Databases ([#12410](#12410)) ([553b11d](553b11d)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#12443](#12443)) ([e385283](e385283)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Azure Private DNS Zone record sets and VNet Links