feat(aws)!: Define primary key for dynamodb_table_continuous_backups #12409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
smokentar
changed the title
disq
approved these changes
Jul 19, 2023
Member
disq
left a comment
disq
left a comment
There was a problem hiding this comment.
LGTM thanks for the contribution!
erezrokah
added
automerge
erezrokah
approved these changes
Jul 19, 2023
| Name: "table_arn", | ||
| Type: arrow.BinaryTypes.String, | ||
| Resolver: schema.ParentColumnResolver("arn"), | ||
| Name: "table_arn", |
Member
There was a problem hiding this comment.
Using the parent as the PK here looks good (unlike #12408 (comment)) as it seems a table can only have a single backups description, see https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_DescribeContinuousBackups.html
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
🤖 I have created a release *beep* *boop* --- ## [22.0.0](plugins-source-aws-v21.1.0...plugins-source-aws-v22.0.0) (2023-07-20) ### ⚠ BREAKING CHANGES * **aws:** Define composite primary key for regions ([#12415](#12415)) * **aws:** Define primary key for s3_bucket_encryption_rules ([#12408](#12408)) * **aws:** Define primary key for dynamodb_table_continuous_backups ([#12409](#12409)) * **aws:** Define composite primary key for lambda_function_versions ([#12402](#12402)) ### This Release has the Following Changes to Tables - Table `aws_appconfig_deployment_strategies` was added - Table `aws_dynamodb_table_continuous_backups`: primary key constraint added to column `table_arn` (:warning: breaking) - Table `aws_dynamodb_table_continuous_backups`: primary key constraint removed from column `_cq_id` (:warning: breaking) - Table `aws_lambda_function_versions`: primary key constraint added to column `function_arn` (:warning: breaking) - Table `aws_lambda_function_versions`: primary key constraint added to column `version` (:warning: breaking) - Table `aws_lambda_function_versions`: primary key constraint removed from column `_cq_id` (:warning: breaking) - Table `aws_regions`: primary key constraint added to column `account_id` (:warning: breaking) - Table `aws_regions`: primary key constraint added to column `region` (:warning: breaking) - Table `aws_regions`: primary key constraint removed from column `_cq_id` (:warning: breaking) - Table `aws_s3_bucket_encryption_rules`: primary key constraint added to column `bucket_arn` (:warning: breaking) - Table `aws_s3_bucket_encryption_rules`: primary key constraint removed from column `_cq_id` (:warning: breaking) ### Features * **aws:** Define composite primary key for lambda_function_versions ([#12402](#12402)) ([d1add18](d1add18)) * **aws:** Define composite primary key for regions ([#12415](#12415)) ([681ea97](681ea97)) * **aws:** Define primary key for dynamodb_table_continuous_backups ([#12409](#12409)) ([7d4a657](7d4a657)) * **aws:** Define primary key for s3_bucket_encryption_rules ([#12408](#12408)) ([a026b98](a026b98)) ### Bug Fixes * **sync:** Pass `DeterministicCQID` option to scheduler ([#12424](#12424)) ([eaac2e6](eaac2e6)) * Use correct name for `DeploymentStrategies` table ([#12428](#12428)) ([dda4205](dda4205)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is aimed to address #12395 by creating a primary key (
table_arn) onaws_dynamodb_table_continuous_backupstable.