-
Notifications
You must be signed in to change notification settings - Fork 547
fix(migration): Make it clear that migration can be done manually and not only via migrate_mode: forced
#12390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not only via `migrate_mode: forced`
disq
approved these changes
Jul 18, 2023
This was referenced Jul 18, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [2.2.5](plugins-destination-mongodb-v2.2.4...plugins-destination-mongodb-v2.2.5) (2023-07-25) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#12443](#12443)) ([e385283](e385283)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.3 ([#12307](#12307)) ([8f14e4d](8f14e4d)) * **migration:** Make it clear that migration can be done manually and not only via `migrate_mode: forced` ([#12390](#12390)) ([33d39cf](33d39cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [2.4.4](plugins-destination-sqlite-v2.4.3...plugins-destination-sqlite-v2.4.4) (2023-07-25) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#12443](#12443)) ([e385283](e385283)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.3 ([#12307](#12307)) ([8f14e4d](8f14e4d)) * **migration:** Make it clear that migration can be done manually and not only via `migrate_mode: forced` ([#12390](#12390)) ([33d39cf](33d39cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [4.3.2](plugins-destination-mssql-v4.3.1...plugins-destination-mssql-v4.3.2) (2023-07-25) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#12443](#12443)) ([e385283](e385283)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.3 ([#12307](#12307)) ([8f14e4d](8f14e4d)) * **migration:** Make it clear that migration can be done manually and not only via `migrate_mode: forced` ([#12390](#12390)) ([33d39cf](33d39cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [2.2.2](plugins-destination-meilisearch-v2.2.1...plugins-destination-meilisearch-v2.2.2) (2023-07-25) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#12443](#12443)) ([e385283](e385283)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.3 ([#12307](#12307)) ([8f14e4d](8f14e4d)) * **migration:** Make it clear that migration can be done manually and not only via `migrate_mode: forced` ([#12390](#12390)) ([33d39cf](33d39cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.1](plugins-destination-mysql-v3.0.0...plugins-destination-mysql-v3.0.1) (2023-07-25) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#12443](#12443)) ([e385283](e385283)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.3 ([#12307](#12307)) ([8f14e4d](8f14e4d)) * **migration:** Make it clear that migration can be done manually and not only via `migrate_mode: forced` ([#12390](#12390)) ([33d39cf](33d39cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [3.3.2](plugins-destination-clickhouse-v3.3.1...plugins-destination-clickhouse-v3.3.2) (2023-07-25) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#12443](#12443)) ([e385283](e385283)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.3 ([#12307](#12307)) ([8f14e4d](8f14e4d)) * **migration:** Make it clear that migration can be done manually and not only via `migrate_mode: forced` ([#12390](#12390)) ([33d39cf](33d39cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.4](plugins-destination-duckdb-v4.1.3...plugins-destination-duckdb-v4.1.4) (2023-07-25) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#12443](#12443)) ([e385283](e385283)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.2.3 ([#12307](#12307)) ([8f14e4d](8f14e4d)) * **migration:** Make it clear that migration can be done manually and not only via `migrate_mode: forced` ([#12390](#12390)) ([33d39cf](33d39cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10545.
PostgreSQL was done in #11662 so I used the message from that PR.
I also aligned the logic in DuckDB to print all tables (taken from the MySQL plugin)