fix: Filter tables in Tables function #12212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
requested review from
a team and
candiduslynx
and removed request for
a team
disq
approved these changes
Jul 14, 2023
erezrokah
added
automerge
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.1](plugins-source-oracledb-v3.0.0...plugins-source-oracledb-v3.0.1) (2023-07-17) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 8e2219b ([#12220](#12220)) ([24e8fb5](24e8fb5)) * Filter tables in Tables function ([#12212](#12212)) ([130ea87](130ea87)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I missed this in #11711.
Without this fix we will always migrate all tables. The sync still works on the filtered tables, so this only impacts migration