fix(mysql)!: Limit truncation of text and blob columns used as primary Keys by setting the prefix to the largest value
#11982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
reviewed
Jul 6, 2023
bbernays
commented
Jul 6, 2023
bbernays
changed the title
bbernays
changed the title
text and blob columns used as primary Keys by setting the prefix to the largest value
candiduslynx
reviewed
Jul 7, 2023
Co-authored-by: Alex Shcherbakov <[email protected]>
candiduslynx
reviewed
Jul 8, 2023
| ) | ||
| // This is necessary because tables are named based on the current time | ||
| // As we iterate through the tests, if we don't sleep here then tables can be created with the same name | ||
| time.Sleep(1 * time.Second) |
Member
There was a problem hiding this comment.
This has been a problem for me too, I'm opening a PR to add a random suffix to the table name cloudquery/plugin-sdk#1086
Co-authored-by: Herman Schaaf <[email protected]>
hermanschaaf
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #11962
BEGIN_COMMIT_OVERRIDE
fix!: This changes the prefix size for
textandblobprimary keys. Previous to this PR only the first 64 characters were included in the primary key, but now it will use maximum supported number of characters (191) in the primary key. Warning logs will be printed if there is any possible truncation. If you are using a source plugin that has a primary key on atextorblobcolumn you will have to usemigrate_mode: forcedto upgrade.END_COMMIT_OVERRIDE