fix(neo4j): Update to SDK v4.4.0-rc1 #11839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
requested review from
a team and
amanenk
and removed request for
a team
candiduslynx
approved these changes
Jun 30, 2023
Contributor
|
@yevgenypats the tests are failing, though |
| plugin.WithTestIgnoreNullsInLists(), | ||
| plugin.WithTestDataOptions(schema.TestSourceOptions{ | ||
| TimePrecision: time.Microsecond, | ||
| SkipMaps: true, |
Contributor
There was a problem hiding this comment.
why are we skipping those now? shouldn't we fix the issue instead?
candiduslynx
suggested changes
Jun 30, 2023
Contributor
candiduslynx
left a comment
candiduslynx
left a comment
There was a problem hiding this comment.
why won't we fix the writing instead?
Contributor
Author
MAP and Structs work now but had to skip lists due to list of list not working. It needs either more granular support on SDK site for test case generation or better support for neo4j. It's not really related to this upgrade so Im going to skip and opened a low-priority issue - #11849 |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 2, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](plugins-destination-neo4j-v3.1.2...plugins-destination-neo4j-v4.0.0) (2023-07-02) ### ⚠ BREAKING CHANGES * **neo4j:** Upgrade to SDK v4 ([#11782](#11782)) ### Features * **neo4j:** Upgrade to SDK v4 ([#11782](#11782)) ([8c59e8b](8c59e8b)) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v13 digest to 5a06b2e ([#11857](#11857)) ([43c2f5f](43c2f5f)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 0656028 ([#11739](#11739)) ([7a6ad49](7a6ad49)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 1e68c51 ([#11637](#11637)) ([46043bc](46043bc)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 43638cb ([#11672](#11672)) ([3c60bbb](3c60bbb)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 4d76231 ([#11532](#11532)) ([6f04233](6f04233)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 8366a22 ([#11717](#11717)) ([8eeff5b](8eeff5b)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 95d3199 ([#11708](#11708)) ([03f214f](03f214f)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to b0832be ([#11651](#11651)) ([71e8c29](71e8c29)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to d864719 ([#11611](#11611)) ([557a290](557a290)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f060192 ([#11730](#11730)) ([c7019c2](c7019c2)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f0dffc6 ([#11689](#11689)) ([18ac0e9](18ac0e9)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.1.0 ([#11665](#11665)) ([d8947c9](d8947c9)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.0 ([#11720](#11720)) ([7ef521d](7ef521d)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.1 ([#11722](#11722)) ([309be72](309be72)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.3 ([#11726](#11726)) ([f0ca611](f0ca611)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.4 ([#11753](#11753)) ([cd4fe1c](cd4fe1c)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.6 ([#11473](#11473)) ([7272133](7272133)) * **neo4j:** Don't order for reading ([#11806](#11806)) ([37cd5ea](37cd5ea)) * **neo4j:** Update to SDK v4.4.0-rc1 ([#11839](#11839)) ([40d02a0](40d02a0)) * Update destinations to v4.4.2-rc1 ([#11872](#11872)) ([bef90db](bef90db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: https://github.com/cloudquery/plugin-sdk/releases/tag/v4.4.0-rc1