Skip to content

Conversation

@yevgenypats
Copy link
Contributor

No description provided.

@yevgenypats yevgenypats requested review from a team and hermanschaaf June 28, 2023 17:22
@cq-bot cq-bot added the duckdb label Jun 28, 2023
@yevgenypats yevgenypats requested review from disq and removed request for hermanschaaf June 28, 2023 17:26
@yevgenypats yevgenypats requested a review from disq June 28, 2023 19:50
@yevgenypats yevgenypats added the automerge Automatically merge once required checks pass label Jun 29, 2023
ConnectionString string `json:"connection_string,omitempty"`
BatchSize int `json:"batch_size,omitempty"`
BatchSizeBytes int `json:"batch_size_bytes,omitempty"`
Development bool `json:"development,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can call this debug?

},
backoff.WithContext(backoff.WithMaxRetries(backoff.NewConstantBackOff(50*time.Millisecond), 3), ctx),
)
// return backoff.Retry(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we're still missing some retry code

@yevgenypats yevgenypats requested a review from hermanschaaf June 29, 2023 14:16
@kodiakhq kodiakhq bot merged commit 8631dbf into main Jun 29, 2023
@kodiakhq kodiakhq bot deleted the fix/duckdb_sdkv4 branch June 29, 2023 14:22
kodiakhq bot pushed a commit that referenced this pull request Jul 2, 2023
🤖 I have created a release *beep* *boop*
---


## [4.1.0](plugins-destination-duckdb-v4.0.3...plugins-destination-duckdb-v4.1.0) (2023-07-02)


### Features

* **duckdb:** Update to SDK v4.1.0-rc1 ([#11802](#11802)) ([8631dbf](8631dbf))


### Bug Fixes

* **deps:** Update github.com/apache/arrow/go/v13 digest to 5a06b2e ([#11857](#11857)) ([43c2f5f](43c2f5f))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 0656028 ([#11739](#11739)) ([7a6ad49](7a6ad49))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 8366a22 ([#11717](#11717)) ([8eeff5b](8eeff5b))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 95d3199 ([#11708](#11708)) ([03f214f](03f214f))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f060192 ([#11730](#11730)) ([c7019c2](c7019c2))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.0 ([#11720](#11720)) ([7ef521d](7ef521d))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.1 ([#11722](#11722)) ([309be72](309be72))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.3 ([#11726](#11726)) ([f0ca611](f0ca611))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.4 ([#11753](#11753)) ([cd4fe1c](cd4fe1c))
* **duckdb:** Update SDK to v4.4.0-rc1 ([#11834](#11834)) ([33d6a40](33d6a40))
* **duckdb:** Update to SDK v4.4.0-rc1 ([#11851](#11851)) ([aade378](aade378))
* Update destinations to v4.4.2-rc1 ([#11872](#11872)) ([bef90db](bef90db))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants