fix: CLI v4: issue config deprecation warnings, pass options to plugin-level spec #11766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
reviewed
Jun 26, 2023
This was referenced Jun 26, 2023
disq
reviewed
Jun 27, 2023
disq
reviewed
Jun 27, 2023
disq
reviewed
Jun 28, 2023
cli/cmd/specs.go
Outdated
| Concurrency: spec.Concurrency, | ||
| TableConcurrency: spec.TableConcurrency, | ||
| ResourceConcurrency: spec.ResourceConcurrency, | ||
| Concurrency: spec.Concurrency, // nolint:staticcheck // allow use of deprecated options here for backwards-compatibility |
Member
There was a problem hiding this comment.
Maybe arrange the deprecated options down in the struct together... then the allow use of... comment can be at the top of the 'block'.
disq
reviewed
Jun 28, 2023
| Destinations: make([]*Destination, 0), | ||
| sourcesMap: make(map[string]*Source), | ||
| destinationsMap: make(map[string]*Destination), | ||
| Sources: make([]*Source, 0), |
Member
Author
There was a problem hiding this comment.
It was like this before, but we can clean it up in the next iteration
disq
approved these changes
Jun 28, 2023
Member
disq
left a comment
disq
left a comment
There was a problem hiding this comment.
just a few nits for readability.
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
🤖 I have created a release *beep* *boop* --- ## [3.6.0](cli-v3.5.4...cli-v3.6.0) (2023-06-28) ### Features * **cli:** Upgrade to SDK v4, protocol v3 ([#11683](#11683)) ([1593f2d](1593f2d)) ### Bug Fixes * CLI v4: issue config deprecation warnings, pass options to plugin-level spec ([#11766](#11766)) ([16264a0](16264a0)) * **CLI:** Multiple migrations ([#11791](#11791)) ([df01ac4](df01ac4)) * **cli:** Set SkipDependentTables, DeterministicCqId ([#11759](#11759)) ([2bcb1c9](2bcb1c9)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.0 ([#11720](#11720)) ([7ef521d](7ef521d)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.1 ([#11722](#11722)) ([309be72](309be72)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.3 ([#11726](#11726)) ([f0ca611](f0ca611)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.4 ([#11753](#11753)) ([cd4fe1c](cd4fe1c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the V4 CLI to log deprecation warnings for config fields that are moving to the plugin spec level, and forward the settings to the plugin if they are still in use.