feat(firestore)!: Update to SDK V4 #11701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
requested review from
a team and
hermanschaaf
and removed request for
a team
erezrokah
changed the title
erezrokah
force-pushed
the
fix/update_firestore_source_sdk_v4
branch
from
6e980a6 to
cbfa97a
Compare
erezrokah
commented
Jun 21, 2023
|
|
||
| func (c *Client) syncTables(ctx context.Context, res chan<- *schema.Resource) error { | ||
| eg, ctx := errgroup.WithContext(ctx) | ||
| eg.SetLimit(len(c.Tables)) |
Member
Author
There was a problem hiding this comment.
No point of setting the limit to the number of tables as that's exactly the number of Go Routines that are created in the loop below
erezrokah
commented
Jun 21, 2023
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestDynamicTables(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
I'll add a full Sync test instead of this one
erezrokah
force-pushed
the
fix/update_firestore_source_sdk_v4
branch
3 times, most recently
from
9e2d9b8 to
4b019ff
Compare
erezrokah
changed the title
1 task
erezrokah
force-pushed
the
fix/update_firestore_source_sdk_v4
branch
2 times, most recently
from
e7bef08 to
d0c638a
Compare
erezrokah
force-pushed
the
fix/update_firestore_source_sdk_v4
branch
from
45a5823 to
db32291
Compare
yevgenypats
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to #11696.
Still need to test thisFIxes #11756
BEGIN_COMMIT_OVERRIDE
feat!: Upgrades the firestore source plugin to use plugin-sdk v4. This version does not contain any user-facing breaking changes, but because it is now using CloudQuery gRPC protocol v3, it does require use of a destination plugin that also supports protocol v3. All recent destination plugin versions support this.
END_COMMIT_OVERRIDE