feat(mysql)!: Update to SDK V4 #11696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
requested review from
a team and
yevgenypats
and removed request for
a team
erezrokah
force-pushed
the
fix/update_mysql_source_sdk_v4
branch
from
956d15a to
8917d0d
Compare
erezrokah
commented
Jun 22, 2023
| require.Equal(t, expectedStrings, actualStrings) | ||
| sortResults(testTable, actualRecords) | ||
|
|
||
| for recordIndex, expectedRecord := range expectedRecords { |
Member
Author
There was a problem hiding this comment.
Notice we switched from string comparison to value comparison as everything is arrow types now
erezrokah
commented
Jun 22, 2023
erezrokah
force-pushed
the
fix/update_mysql_source_sdk_v4
branch
from
8917d0d to
4e19c73
Compare
erezrokah
force-pushed
the
fix/update_mysql_source_sdk_v4
branch
3 times, most recently
from
9894578 to
ee4b344
Compare
erezrokah
changed the title
erezrokah
force-pushed
the
fix/update_mysql_source_sdk_v4
branch
from
c8207bb to
d9396ac
Compare
1 task
erezrokah
force-pushed
the
fix/update_mysql_source_sdk_v4
branch
from
d9396ac to
b8591f9
Compare
erezrokah
force-pushed
the
fix/update_mysql_source_sdk_v4
branch
3 times, most recently
from
c500922 to
be9ef8d
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
#### Summary Same as #11696 Fixes #11757 BEGIN_COMMIT_OVERRIDE feat!: Upgrades the oracledb source plugin to use plugin-sdk v4. This version does not contain any user-facing breaking changes, but because it is now using CloudQuery gRPC protocol v3, it does require use of a destination plugin that also supports protocol v3. All recent destination plugin versions support this. END_COMMIT_OVERRIDE <!--
erezrokah
force-pushed
the
fix/update_mysql_source_sdk_v4
branch
from
86219f4 to
4525ed3
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
#### Summary Similar to #11696. ~~I had to comment change some of the tests due to cloudquery/plugin-sdk#982 and cloudquery/plugin-sdk#915 (comment), so not ready to merge~~ BEGIN_COMMIT_OVERRIDE feat!: Upgrades the postgresql source plugin to use plugin-sdk v4. This version does not contain any user-facing breaking changes, but because it is now using CloudQuery gRPC protocol v3, it does require use of a destination plugin that also supports protocol v3. All recent destination plugin versions support this. feat!: To enable CDC in this version you'll need to use the `cdc_id` configuration string property, instead of the `cdc` boolean one. Please refer to the [docs](https://www.cloudquery.io/docs/plugins/sources/postgresql/overview) for more information END_COMMIT_OVERRIDE <!--
yevgenypats
approved these changes
Jul 17, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
#### Summary Similar to #11696. ~~Still need to test this~~ FIxes #11756 BEGIN_COMMIT_OVERRIDE feat!: Upgrades the firestore source plugin to use plugin-sdk v4. This version does not contain any user-facing breaking changes, but because it is now using CloudQuery gRPC protocol v3, it does require use of a destination plugin that also supports protocol v3. All recent destination plugin versions support this. END_COMMIT_OVERRIDE <!--
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is based on the MemDB plugin from cloudquery/plugin-sdk#915
Fixes #11755
BEGIN_COMMIT_OVERRIDE
feat!: Upgrades the mysql source plugin to use plugin-sdk v4. This version does not contain any user-facing breaking changes, but because it is now using CloudQuery gRPC protocol v3, it does require use of a destination plugin that also supports protocol v3. All recent destination plugin versions support this.
END_COMMIT_OVERRIDE